clang 7.0 support - individual warning levels

.gitignore

@@ -1,2 +1,3 @@
-.vscode
 build
+.vscode
+

.travis.yml

@@ -127,15 +127,15 @@ matrix:
           packages: ['g++-4.8-multilib', 'libboost-all-dev']
       env: COMPILER=g++-4.8 ARCH=x86_64 CONF=Release UNIT_TESTS=false BUILD_EXAMPLES=true BUILD_BENCHMARKS=true
 
+    # Linux / CLang
     - os: linux
       compiler: clang
       addons:
         apt:
           sources: ['ubuntu-toolchain-r-test']
           packages: ['g++-4.8-multilib', 'libboost-all-dev']
       env: LLVM_VERSION=3.8.0 ARCH=x86_64 CONF=Release UNIT_TESTS=false BUILD_EXAMPLES=true BUILD_BENCHMARKS=true
-
-    # Linux / CLang
+
     # this config fails at the moment because of disabled APT on llvm
     - os: linux
       compiler: clang
@@ -177,17 +177,34 @@ matrix:
           sources: ['ubuntu-toolchain-r-test']
           packages: ['g++-4.8-multilib']
       env: LLVM_VERSION=3.8.0 ARCH=x86_64 CONF=Release UNIT_TESTS=true
+
+    - os: linux
+      compiler: clang
+      addons:
+        apt:
+          sources: ['ubuntu-toolchain-r-test', 'llvm-toolchain-trusty-5.0']
+          packages: ['g++-6', 'clang-5.0',]
+      env: LLVM_VERSION=5.0.0 ARCH=x86_64 CONF=Release UNIT_TESTS=true
 
     # OSX/Clang
     - os: osx
-      osx_image: xcode7.3
+      osx_image: xcode9.2
+      compiler: clang
+      env: COMPILER=clang++ ARCH=x86 CONF=Release UNIT_TESTS=true
+
+    - os: osx
+      osx_image: xcode9.2
+      compiler: clang
+      env: COMPILER=clang++ ARCH=x86_64 CONF=Release UNIT_TESTS=true
+    - os: osx
+      osx_image: xcode8.3
       compiler: clang
       env: COMPILER=clang++ ARCH=x86 CONF=Release UNIT_TESTS=true
 
     - os: osx
-      osx_image: xcode7.3
+      osx_image: xcode8.3
       compiler: clang
-      env: COMPILER=clang++ ARCH=x86_64 CONF=Release UNIT_TESTS=true      
+      env: COMPILER=clang++ ARCH=x86_64 CONF=Release UNIT_TESTS=true         
 
   allow_failures:
     - env: COMPILER=clang++-3.7 ARCH=x86_64 CONF=Release UNIT_TESTS=true

CMake/config.cmake

@@ -113,17 +113,21 @@ endif()
 
 enable_rtti(BUILD_WITH_RTTI)
 
+# cxx default flags 
 if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
   if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.7.0")
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x -Wall -Werror")
-    message(STATUS "added flag -std=c++0x, -Wall, -Werror to g++")
+    set(ADDITIONAL_COMPILER_FLAGS "-std=c++0x -Wall")
+  elseif(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "7.0.0")
+    set(ADDITIONAL_COMPILER_FLAGS "-std=c++17 -Wall")
+    SET(BUILD_BENCHMARKS FALSE)
   else()
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Werror")
-    message(STATUS "added flag -std=c++11, -Wall, -Werror to g++")
+    set(ADDITIONAL_COMPILER_FLAGS "-std=c++11 -Wall")
   endif()
   if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "4.0.0")
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
+    set(ADDITIONAL_COMPILER_FLAGS "${ADDITIONAL_COMPILER_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
   endif()
+
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ADDITIONAL_COMPILER_FLAGS}")
 
   if(MINGW)
     set(GNU_STATIC_LINKER_FLAGS "-static-libgcc -static-libstdc++ -static")
@@ -133,20 +137,22 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
 endif()
 
 if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Werror")
-  message(STATUS "added flag -std=c++11, -Wall, -Werror to g++")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
-  message(WARNING "clang support is currently experimental")
-
+  if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "4.0.0")
+      set(ADDITIONAL_COMPILER_FLAGS "-std=c++17 -Wall")
+  else()
+      set(ADDITIONAL_COMPILER_FLAGS "-std=c++11 -Wall")
+      set(ADDITIONAL_COMPILER_FLAGS "${ADDITIONAL_COMPILER_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
+  endif()
+
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ADDITIONAL_COMPILER_FLAGS}")
+
   set(CLANG_STATIC_LINKER_FLAGS "-stdlib=libc++ -static-libstdc++")
 endif()
 
-if(MSVC)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj /WX")
-    replaceCompilerOption("/W3" "/W4")
-    message(STATUS "added flag /bigobj, /W4 to MSVC compiler")
-    message(STATUS "Treats all compiler warnings as errors.")
+if(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj /Wall")
 endif()
+message(STATUS "Set the following CXX Flags: '${CMAKE_CXX_FLAGS}', Warning levels are added project level specific!")
 
 # RelWithDepInfo should have the same option like the Release build
 # but of course with Debug informations
@@ -163,6 +169,7 @@ else()
   message(WARNING "Please adjust CMAKE_CXX_FLAGS_RELWITHDEBINFO flags for this compiler!")
 endif()
 
+# cmake config file
 include(CMakePackageConfigHelpers)
 write_basic_package_version_file(
   "${CMAKE_CURRENT_BINARY_DIR}/CMake/rttr-config-version.cmake"

CMake/utility.cmake

@@ -386,6 +386,51 @@ function(activate_precompiled_headers _PRECOMPILED_HEADER _SOURCE_FILES)
   endif()
 endfunction()
 
+####################################################################################
+# Adds warnings compiler options to the target depending on the category
+# _TARGET Target name
+# _CATEGORY "library" or "unit_tests" or "benchmarks"
+####################################################################################
+macro( add_warning_levels _TARGET _CATEGORY)
+  if("${_CATEGORY}" STREQUAL "library" OR "${_CATEGORY}" STREQUAL "examples")
+    if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+      set(CXX_FLAGS "-Werror")
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+      set(CXX_FLAGS "-Werror")
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
+      set(CXX_FLAGS "/WX" "/W4")
+    else()
+      message(FATAL_ERROR "Unknown compiler to set warning levels: ${_CATEGORY} for target ${_TARGET}! ")
+    endif()
+  elseif("${_CATEGORY}" STREQUAL "unit_tests")
+    if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+      set(CXX_FLAGS "-Werror" "-Wno-unused-private-field" "-Wno-delete-non-virtual-dtor")
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+      set(CXX_FLAGS "-Werror" "-Wno-unused-private-field" "-Wno-delete-non-virtual-dtor")
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
+      set(CXX_FLAGS "/WX" "/W4")
+    else()
+      message(FATAL_ERROR "Unknown compiler to set warning levels: ${_CATEGORY} for target ${_TARGET}! ")
+    endif()
+  elseif("${_CATEGORY}" STREQUAL "benchmarks")
+    if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+      set(CXX_FLAGS "-Werror" "-Wno-unused-private-field" "-Wno-delete-non-virtual-dtor")
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+      set(CXX_FLAGS "-Werror" "-Wno-unused-private-field" "-Wno-delete-non-virtual-dtor")
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
+      set(CXX_FLAGS "/WX" "/W4")
+    else()
+      message(FATAL_ERROR "Unknown compiler to set warning levels: ${_CATEGORY} for target ${_TARGET}! ")
+    endif()
+  endif()
+
+  target_compile_options(${_TARGET} PRIVATE ${CXX_FLAGS} )
+  target_compile_options(${_TARGET} PRIVATE $<$<CONFIG:Debug>:${CXX_FLAGS_DEBUG}> )
+  target_compile_options(${_TARGET} PRIVATE $<$<CONFIG:Release>:${CXX_FLAGS_RELEASE}> )
+  target_compile_options(${_TARGET} PRIVATE $<$<CONFIG:MinSizeRel>:${CXX_FLAGS_MINSIZEREL}> )
+  target_compile_options(${_TARGET} PRIVATE $<$<CONFIG:RelWithDebInfo>:${CXX_FLAGS_RELWITHDEBINFO}> )
+endmacro()
+
 ####################################################################################
 # Adds or replace a compiler option
 # _OLD_OPTION The option which should be replaced
@@ -396,7 +441,7 @@ macro( replaceCompilerOption _OLD_OPTION _NEW_OPTION)
           CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE
           CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO)
     if(${flag_var} MATCHES ${_OLD_OPTION})
-      string(REGEX REPLACE ${_OLD_OPTION} ${_NEW_OPTION} ${flag_var} "${${flag_var}}")
+      string(REGEX REPLACE "${_OLD_OPTION}" "${_NEW_OPTION}" ${flag_var} "${${flag_var}}")
     else()
       set(${flag_var} "${${flag_var}} ${_NEW_OPTION}")
     endif()
@@ -504,4 +549,4 @@ macro(generateLibraryVersionVariables MAJOR MINOR PATCH PRODUCT_NAME PRODUCT_CPY
   set(LIBRARY_PRODUCT_NAME ${PRODUCT_NAME})
   set(LIBRARY_COPYRIGHT ${PRODUCT_CPY_RIGHT})
   set(LIBRARY_LICENSE ${PRODUCT_LICENSE})
-endmacro()
+endmacro()

src/benchmarks/bench_method/CMakeLists.txt

@@ -54,6 +54,7 @@ if(MSVC)
     set_target_properties(bench_method PROPERTIES COMPILE_FLAGS "/Zm200")
 endif()
 
+add_warning_levels(bench_method "benchmarks")
 set_target_properties(bench_method PROPERTIES DEBUG_POSTFIX _d
                                               FOLDER "Benchmarks"
                                               INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -81,6 +82,7 @@ if (BUILD_STATIC)
         set_target_properties(bench_method_lib PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
     endif()
 
+    add_warning_levels(bench_method_lib "benchmarks")
     set_target_properties(bench_method_lib PROPERTIES DEBUG_POSTFIX _d
                                                       FOLDER "Benchmarks"
                                                       INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -110,6 +112,7 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
         set_target_properties(bench_method_s PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
     endif()
 
+    add_warning_levels(bench_method_s "benchmarks")
     set_target_properties(bench_method_s PROPERTIES DEBUG_POSTFIX _d
                                                     FOLDER "Benchmarks"
                                                     INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -146,6 +149,7 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
             set_target_properties(bench_method_lib_s PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
         endif()
 
+        add_warning_levels(bench_method_lib_s "benchmarks")
         set_target_properties(bench_method_lib_s PROPERTIES DEBUG_POSTFIX _d
                                                             FOLDER "Benchmarks"
                                                             INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")

src/benchmarks/bench_rttr_cast/CMakeLists.txt

@@ -53,6 +53,7 @@ target_compile_definitions(bench_rttr_cast PUBLIC BOOST_ALL_NO_LIB)
 if(MSVC)
     set_target_properties(bench_rttr_cast PROPERTIES COMPILE_FLAGS "/Zm200")
 endif()
+add_warning_levels(bench_rttr_cast "benchmarks")
 set_target_properties(bench_rttr_cast PROPERTIES DEBUG_POSTFIX _d
                                                  FOLDER "Benchmarks"
                                                  INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -81,6 +82,7 @@ if (BUILD_STATIC)
         set_target_properties(bench_rttr_cast_lib PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
     endif()
 
+    add_warning_levels(bench_rttr_cast_lib "benchmarks")
     set_target_properties(bench_rttr_cast_lib PROPERTIES DEBUG_POSTFIX _d
                                                          FOLDER "Benchmarks"
                                                          INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -110,6 +112,7 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
         set_target_properties(bench_rttr_cast_s PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
     endif()
 
+    add_warning_levels(bench_rttr_cast_s "benchmarks")
     set_target_properties(bench_rttr_cast_s PROPERTIES DEBUG_POSTFIX _d
                                                        FOLDER "Benchmarks"
                                                        INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -146,6 +149,7 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
             set_target_properties(bench_rttr_cast_lib_s PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
         endif()
 
+        add_warning_levels(bench_rttr_cast_lib_s "benchmarks")
         set_target_properties(bench_rttr_cast_lib_s PROPERTIES DEBUG_POSTFIX _d
                                                                FOLDER "Benchmarks"
                                                                INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")

src/benchmarks/bench_variant/CMakeLists.txt

@@ -54,6 +54,7 @@ if(MSVC)
     set_target_properties(bench_variant PROPERTIES COMPILE_FLAGS "/Zm200")
 endif()
 
+add_warning_levels(bench_variant "benchmarks")
 set_target_properties(bench_variant PROPERTIES DEBUG_POSTFIX _d
                                                FOLDER "Benchmarks"
                                                INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -82,6 +83,7 @@ if (BUILD_STATIC)
         set_target_properties(bench_variant_lib PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
     endif()
 
+    add_warning_levels(bench_variant_lib "benchmarks")
     set_target_properties(bench_variant_lib PROPERTIES DEBUG_POSTFIX _d
                                                        FOLDER "Benchmarks"
                                                        INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -111,6 +113,7 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
         set_target_properties(bench_variant_s PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
     endif()
 
+    add_warning_levels(bench_variant_s "benchmarks")
     set_target_properties(bench_variant_s PROPERTIES DEBUG_POSTFIX _d
                                                      FOLDER "Benchmarks"
                                                      INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
@@ -147,6 +150,7 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
             set_target_properties(bench_variant_lib_s PROPERTIES COMPILE_FLAGS "/Zm200 /bigobj")
         endif()
 
+        add_warning_levels(bench_variant_lib_s "benchmarks")
         set_target_properties(bench_variant_lib_s PROPERTIES DEBUG_POSTFIX _d
                                                              FOLDER "Benchmarks"
                                                              INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")

src/examples/json_serialization/CMakeLists.txt

@@ -46,6 +46,7 @@ set_target_properties(json_serialization PROPERTIES DEBUG_POSTFIX _d
                                                     FOLDER "Examples"
                                                     INSTALL_RPATH "${RTTR_EXECUTABLE_INSTALL_RPATH}")
 
+add_warning_levels(json_serialization "examples")
 
 message(STATUS "Scanning " ${PROJECT_NAME} " module finished!")
 message(STATUS "")

src/rttr/CMakeLists.txt

@@ -46,6 +46,8 @@ if (${BUILD_RTTR_DYNAMIC})
     target_compile_definitions(rttr_core PRIVATE RTTR_DLL_EXPORTS)
     target_compile_definitions(rttr_core PUBLIC RTTR_DLL)
 
+    add_warning_levels(rttr_core "library")
+
     set_target_properties(rttr_core PROPERTIES
                           VERSION ${RTTR_VERSION} SOVERSION ${RTTR_VERSION}
                           EXPORT_NAME Core
@@ -77,7 +79,9 @@ endif()
 if (BUILD_STATIC)
     add_library(rttr_core_lib STATIC ${UnityBuild} ${SRC_FILES} ${HPP_FILES})
     add_library(RTTR::Core_Lib ALIAS rttr_core_lib)
-
+
+    add_warning_levels(rttr_core_lib "library")
+
     set_target_properties(rttr_core_lib PROPERTIES
                           VERSION ${RTTR_VERSION} SOVERSION ${RTTR_VERSION}
                           EXPORT_NAME Core_Lib
@@ -89,7 +93,7 @@ if (BUILD_STATIC)
     elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
         set_target_properties(rttr_core_lib PROPERTIES OUTPUT_NAME rttr_core)
     else()
-        message(SEND_ERROR "Do now know how to to name the static library.")
+        message(SEND_ERROR "Do not know how to name the static library.")
     endif()
 
     target_include_directories(rttr_core_lib PUBLIC
@@ -113,10 +117,12 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
     target_compile_definitions(rttr_core_s PRIVATE RTTR_DLL_EXPORTS)
     target_compile_definitions(rttr_core_s PUBLIC RTTR_DLL)
 
+    add_warning_levels(rttr_core_s "library")
+
     target_include_directories(rttr_core_s PUBLIC
-    $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../>
-    $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../>
-    $<INSTALL_INTERFACE:include>)
+                               $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../>
+                               $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../>
+                               $<INSTALL_INTERFACE:include>)
 
     set_target_properties(rttr_core_s PROPERTIES
                           VERSION ${RTTR_VERSION} SOVERSION ${RTTR_VERSION}
@@ -130,7 +136,7 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
     elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
         set_target_properties(rttr_core_s PROPERTIES LINK_FLAGS ${CLANG_STATIC_LINKER_FLAGS})
     else()
-        message(SEND_ERROR "Do now know how to statically link against the standard library with this compiler.")
+        message(SEND_ERROR "Do not know how to statically link against the standard library with this compiler.")
     endif()
 
     if (BUILD_INSTALLER)
@@ -146,10 +152,12 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
         add_library(rttr_core_lib_s STATIC ${UnityBuild} ${SRC_FILES} ${HPP_FILES})
         add_library(RTTR::Core_Lib_STL ALIAS rttr_core_lib_s)
 
+        add_warning_levels(rttr_core_lib_s "library")
+
         target_include_directories(rttr_core_lib_s PUBLIC
-        $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../>
-        $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../>
-        $<INSTALL_INTERFACE:include>)
+                                   $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../>
+                                   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../>
+                                   $<INSTALL_INTERFACE:include>)
 
         set_target_properties(rttr_core_lib_s PROPERTIES
                               VERSION ${RTTR_VERSION} SOVERSION ${RTTR_VERSION}
@@ -163,7 +171,7 @@ if (BUILD_WITH_STATIC_RUNTIME_LIBS)
         elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
             set_target_properties(rttr_core_lib_s PROPERTIES LINK_FLAGS ${CLANG_STATIC_LINKER_FLAGS} OUTPUT_NAME rttr_core_s)
         else()
-            message(SEND_ERROR "Do now know how to statically link against the standard library with this compiler.")
+            message(SEND_ERROR "Do not know how to statically link against the standard library with this compiler.")
         endif()
 
         if (BUILD_INSTALLER)