added support for c++17 compilers #107

acki-m · 2018-01-23T23:49:16Z

a lot of warning poped up from g++7
"will change in C++17 because the exception specification is part of a function type [-Werror=noexcept-type]"
These can be remove when compiling with c++17 compiler flag

Additionally: VS2015 and greater will now use noexcept, was not enabled by accident
The benchmarks has to be disabled, because of compile errors in noniuose (no warnings)
libnonius/nonius#97

a lot of warning poped up from g++7 "will change in C++17 because the exception specification is part of a function type [-Werror=noexcept-type]" These can be remove when compiling with c++17 compiler flag Additionally: VS2015 and greater will now use noexcept, was not enabled by accident The benchmarks has to be disabled, because of compile errors in noniuose (no warnings) libnonius/nonius#97

e.g: "Warning C4714: function 'class rttr::type __thiscall rttr::detail::variant_sequential_view_private::get_rank_type(unsigned int)const ' marked as __forceinline"

gabyx · 2018-01-24T13:21:36Z

can we merge my disable-warning PR #100 improvements together with this one, and work on this in one PR? otherwise my work is kind of lost...

updated MacOSX images to 9.3 & 8.3

… number

coveralls · 2018-01-25T16:31:54Z

Coverage increased (+0.1%) to 90.235% when pulling 67d9920 on acki-m:feature-add-cpp17-compiler-support into 29e6ff9 on rttrorg:master.

gabyx · 2018-01-25T20:38:00Z

Strangly clang++ 7.0 does not define

#if __has_feature(__cxx_noexcept_function_type)
#error("asd")
#endif
int main()
{
}

This does not compile as it should. also clang documentation does not say anythin about it: https://clang.llvm.org/docs/LanguageExtensions.html#langext-has-feature-back-compat

gabyx · 2018-01-25T21:12:10Z

I made some progress building, merged your PR #107
clang 7.0 builds now everthing including benchmarks, and they work.
However as clang7.0 does not define __cxx_noexcept_function_typeI had to make a hack in core_prerequisites.h.

acki-m · 2018-01-27T14:44:49Z

@gabyx
because this macro does not exist in clang
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4518.html

The recommended feature-test macro is __cpp_noexcept_function_type.

We have to use the one without xx

* some clean up of the travis script (no more downloading of clang from llvm website)

private field 'm_value' is not used [-Werror,-Wunused-private-field]

gabyx · 2018-01-27T23:32:38Z

hm ah :) I only looked on cpp reference :). crazy how much one needs to know to make it feasible. have you already thought about de flags? in the video he says cmake should find out what compiler flags one should use? I have no clue how he meant it. I mean to compile the library one needs at least -std=...., he also mentioned not to use Werror... Is there a way to give a set of compile flags such that when cmake finds the library and import its target they are reasonable and make sense. So far nothing is imposed when you use find_package? i think this is good so isnt it?

…ke choose the appropriate flag It will be tryed to use the latest c++ standard (atm. C++17) However, at least c++11 compiler is required ( this info will now be stored and checked in the generated cmake scripts) - removed useless dependency settings in the benchmarks (DRY) - added new cmake function for settting default compiler warnings

gabyx · 2018-01-29T23:23:52Z

looks very good!

gabyx · 2018-01-29T23:24:32Z

I think my branch gets obsolete, which is good =)

so we can avoid initialization of the c compiler from cmake

added function overload to select const/non const function with 'noexcept' specifier

Otherwise, we get following compile error: /usr/include/linux/errno.h:1:23: fatal error: asm/errno.h: No such file or directory #include <asm/errno.h>

new cmake func: get_latest_supported_cxx * moved clang travis ci jobs down again It is possibel to mix a new compiler with an old standard library (e.g. clang 4.0 with c++17 support and using c++14 STL version, this leeds to the latest problems)

gabyx · 2018-01-31T19:18:21Z

I merged all your change, I still left my set_warning_levels to be able to compile everything also the benchmarks and tests.
with clang7.0 it works fine on my macOs machine. I will test Apple Clang, supposedly it will break

added download of boost libraries for clang-4.0 build

acki-m · 2018-01-31T19:30:56Z

Now, it should build all linux targets fine (when travis will retrieve the package)
I think the apple clang issues are coming from different clang version scheme or mixing older standard libraries and new compiler version.

PS: for your tests, I suggest moving the macOSX clang targets on top.
PPS: When builds fail, can you cancel them on travis?

gabyx · 2018-02-01T19:36:33Z

we have some problems with (__clang__ ist not enough I think on macos we need to detect if its the apple clang and then check for the version (https://travis-ci.org/rttrorg/rttr/jobs/335840657) (sucks...)

/Users/travis/build/rttrorg/rttr/src/rttr/../rttr/detail/misc/utility.h:44:1: error: unknown warning group '-Wnoexcept-type', ignored [-Werror,-Wunknown-pragmas]
RTTR_BEGIN_DISABLE_EXCEPT_TYPE_WARNING
^
/Users/travis/build/rttrorg/rttr/src/rttr/../rttr/detail/base/core_prerequisites.h:284:57: note: expanded from macro 'RTTR_BEGIN_DISABLE_EXCEPT_TYPE_WARNING'
                                                        _Pragma ("clang diagnostic ignored \"-Wnoexcept-type\"")
                                                        ^
<scratch space>:137:27: note: expanded from here
 clang diagnostic ignored "-Wnoexcept-type"

gabyx · 2018-02-01T19:43:33Z

may be we need something along the line:
#ifdef __apple_build_version__ > ?????

gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
gcc -x c /dev/null -dM -E
#define OBJC_NEW_PROPERTIES 1
#define _LP64 1
#define __APPLE_CC__ 6000
#define __APPLE__ 1
#define __ATOMIC_ACQUIRE 2
#define __ATOMIC_ACQ_REL 4
#define __ATOMIC_CONSUME 1
#define __ATOMIC_RELAXED 0
#define __ATOMIC_RELEASE 3
#define __ATOMIC_SEQ_CST 5
#define __BIGGEST_ALIGNMENT__ 16
#define __BLOCKS__ 1
#define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
#define __CHAR16_TYPE__ unsigned short
#define __CHAR32_TYPE__ unsigned int
#define __CHAR_BIT__ 8
#define __CONSTANT_CFSTRINGS__ 1
#define __DBL_DECIMAL_DIG__ 17
#define __DBL_DENORM_MIN__ 4.9406564584124654e-324
#define __DBL_DIG__ 15
#define __DBL_EPSILON__ 2.2204460492503131e-16
#define __DBL_HAS_DENORM__ 1
#define __DBL_HAS_INFINITY__ 1
#define __DBL_HAS_QUIET_NAN__ 1
#define __DBL_MANT_DIG__ 53
#define __DBL_MAX_10_EXP__ 308
#define __DBL_MAX_EXP__ 1024
#define __DBL_MAX__ 1.7976931348623157e+308
#define __DBL_MIN_10_EXP__ (-307)
#define __DBL_MIN_EXP__ (-1021)
#define __DBL_MIN__ 2.2250738585072014e-308
#define __DECIMAL_DIG__ __LDBL_DECIMAL_DIG__
#define __DYNAMIC__ 1
#define __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ 101100
#define __FINITE_MATH_ONLY__ 0
#define __FLT_DECIMAL_DIG__ 9
#define __FLT_DENORM_MIN__ 1.40129846e-45F
#define __FLT_DIG__ 6
#define __FLT_EPSILON__ 1.19209290e-7F
#define __FLT_EVAL_METHOD__ 0
#define __FLT_HAS_DENORM__ 1
#define __FLT_HAS_INFINITY__ 1
#define __FLT_HAS_QUIET_NAN__ 1
#define __FLT_MANT_DIG__ 24
#define __FLT_MAX_10_EXP__ 38
#define __FLT_MAX_EXP__ 128
#define __FLT_MAX__ 3.40282347e+38F
#define __FLT_MIN_10_EXP__ (-37)
#define __FLT_MIN_EXP__ (-125)
#define __FLT_MIN__ 1.17549435e-38F
#define __FLT_RADIX__ 2
#define __FXSR__ 1
#define __GCC_ATOMIC_BOOL_LOCK_FREE 2
#define __GCC_ATOMIC_CHAR16_T_LOCK_FREE 2
#define __GCC_ATOMIC_CHAR32_T_LOCK_FREE 2
#define __GCC_ATOMIC_CHAR_LOCK_FREE 2
#define __GCC_ATOMIC_INT_LOCK_FREE 2
#define __GCC_ATOMIC_LLONG_LOCK_FREE 2
#define __GCC_ATOMIC_LONG_LOCK_FREE 2
#define __GCC_ATOMIC_POINTER_LOCK_FREE 2
#define __GCC_ATOMIC_SHORT_LOCK_FREE 2
#define __GCC_ATOMIC_TEST_AND_SET_TRUEVAL 1
#define __GCC_ATOMIC_WCHAR_T_LOCK_FREE 2
#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_1 1
#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 1
#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_2 1
#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 1
#define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8 1
#define __GNUC_MINOR__ 2
#define __GNUC_PATCHLEVEL__ 1
#define __GNUC_STDC_INLINE__ 1
#define __GNUC__ 4
#define __GXX_ABI_VERSION 1002
#define __GXX_RTTI 1
#define __INT16_C_SUFFIX__
#define __INT16_FMTd__ "hd"
#define __INT16_FMTi__ "hi"
#define __INT16_MAX__ 32767
#define __INT16_TYPE__ short
#define __INT32_C_SUFFIX__
#define __INT32_FMTd__ "d"
#define __INT32_FMTi__ "i"
#define __INT32_MAX__ 2147483647
#define __INT32_TYPE__ int
#define __INT64_C_SUFFIX__ LL
#define __INT64_FMTd__ "lld"
#define __INT64_FMTi__ "lli"
#define __INT64_MAX__ 9223372036854775807LL
#define __INT64_TYPE__ long long int
#define __INT8_C_SUFFIX__
#define __INT8_FMTd__ "hhd"
#define __INT8_FMTi__ "hhi"
#define __INT8_MAX__ 127
#define __INT8_TYPE__ signed char
#define __INTMAX_C_SUFFIX__ L
#define __INTMAX_FMTd__ "ld"
#define __INTMAX_FMTi__ "li"
#define __INTMAX_MAX__ 9223372036854775807L
#define __INTMAX_TYPE__ long int
#define __INTMAX_WIDTH__ 64
#define __INTPTR_FMTd__ "ld"
#define __INTPTR_FMTi__ "li"
#define __INTPTR_MAX__ 9223372036854775807L
#define __INTPTR_TYPE__ long int
#define __INTPTR_WIDTH__ 64
#define __INT_FAST16_FMTd__ "hd"
#define __INT_FAST16_FMTi__ "hi"
#define __INT_FAST16_MAX__ 32767
#define __INT_FAST16_TYPE__ short
#define __INT_FAST32_FMTd__ "d"
#define __INT_FAST32_FMTi__ "i"
#define __INT_FAST32_MAX__ 2147483647
#define __INT_FAST32_TYPE__ int
#define __INT_FAST64_FMTd__ "ld"
#define __INT_FAST64_FMTi__ "li"
#define __INT_FAST64_MAX__ 9223372036854775807L
#define __INT_FAST64_TYPE__ long int
#define __INT_FAST8_FMTd__ "hhd"
#define __INT_FAST8_FMTi__ "hhi"
#define __INT_FAST8_MAX__ 127
#define __INT_FAST8_TYPE__ signed char
#define __INT_LEAST16_FMTd__ "hd"
#define __INT_LEAST16_FMTi__ "hi"
#define __INT_LEAST16_MAX__ 32767
#define __INT_LEAST16_TYPE__ short
#define __INT_LEAST32_FMTd__ "d"
#define __INT_LEAST32_FMTi__ "i"
#define __INT_LEAST32_MAX__ 2147483647
#define __INT_LEAST32_TYPE__ int
#define __INT_LEAST64_FMTd__ "ld"
#define __INT_LEAST64_FMTi__ "li"
#define __INT_LEAST64_MAX__ 9223372036854775807L
#define __INT_LEAST64_TYPE__ long int
#define __INT_LEAST8_FMTd__ "hhd"
#define __INT_LEAST8_FMTi__ "hhi"
#define __INT_LEAST8_MAX__ 127
#define __INT_LEAST8_TYPE__ signed char
#define __INT_MAX__ 2147483647
#define __LDBL_DECIMAL_DIG__ 21
#define __LDBL_DENORM_MIN__ 3.64519953188247460253e-4951L
#define __LDBL_DIG__ 18
#define __LDBL_EPSILON__ 1.08420217248550443401e-19L
#define __LDBL_HAS_DENORM__ 1
#define __LDBL_HAS_INFINITY__ 1
#define __LDBL_HAS_QUIET_NAN__ 1
#define __LDBL_MANT_DIG__ 64
#define __LDBL_MAX_10_EXP__ 4932
#define __LDBL_MAX_EXP__ 16384
#define __LDBL_MAX__ 1.18973149535723176502e+4932L
#define __LDBL_MIN_10_EXP__ (-4931)
#define __LDBL_MIN_EXP__ (-16381)
#define __LDBL_MIN__ 3.36210314311209350626e-4932L
#define __LITTLE_ENDIAN__ 1
#define __LONG_LONG_MAX__ 9223372036854775807LL
#define __LONG_MAX__ 9223372036854775807L
#define __LP64__ 1
#define __MACH__ 1
#define __MMX__ 1
#define __NO_INLINE__ 1
#define __NO_MATH_INLINES 1
#define __ORDER_BIG_ENDIAN__ 4321
#define __ORDER_LITTLE_ENDIAN__ 1234
#define __ORDER_PDP_ENDIAN__ 3412
#define __PIC__ 2
#define __POINTER_WIDTH__ 64
#define __PRAGMA_REDEFINE_EXTNAME 1
#define __PTRDIFF_FMTd__ "ld"
#define __PTRDIFF_FMTi__ "li"
#define __PTRDIFF_MAX__ 9223372036854775807L
#define __PTRDIFF_TYPE__ long int
#define __PTRDIFF_WIDTH__ 64
#define __REGISTER_PREFIX__
#define __SCHAR_MAX__ 127
#define __SHRT_MAX__ 32767
#define __SIG_ATOMIC_MAX__ 2147483647
#define __SIG_ATOMIC_WIDTH__ 32
#define __SIZEOF_DOUBLE__ 8
#define __SIZEOF_FLOAT__ 4
#define __SIZEOF_INT128__ 16
#define __SIZEOF_INT__ 4
#define __SIZEOF_LONG_DOUBLE__ 16
#define __SIZEOF_LONG_LONG__ 8
#define __SIZEOF_LONG__ 8
#define __SIZEOF_POINTER__ 8
#define __SIZEOF_PTRDIFF_T__ 8
#define __SIZEOF_SHORT__ 2
#define __SIZEOF_SIZE_T__ 8
#define __SIZEOF_WCHAR_T__ 4
#define __SIZEOF_WINT_T__ 4
#define __SIZE_FMTX__ "lX"
#define __SIZE_FMTo__ "lo"
#define __SIZE_FMTu__ "lu"
#define __SIZE_FMTx__ "lx"
#define __SIZE_MAX__ 18446744073709551615UL
#define __SIZE_TYPE__ long unsigned int
#define __SIZE_WIDTH__ 64
#define __SSE2_MATH__ 1
#define __SSE2__ 1
#define __SSE3__ 1
#define __SSE_MATH__ 1
#define __SSE__ 1
#define __SSP__ 1
#define __SSSE3__ 1
#define __STDC_HOSTED__ 1
#define __STDC_UTF_16__ 1
#define __STDC_UTF_32__ 1
#define __STDC_VERSION__ 201112L
#define __STDC__ 1
#define __UINT16_C_SUFFIX__
#define __UINT16_FMTX__ "hX"
#define __UINT16_FMTo__ "ho"
#define __UINT16_FMTu__ "hu"
#define __UINT16_FMTx__ "hx"
#define __UINT16_MAX__ 65535
#define __UINT16_TYPE__ unsigned short
#define __UINT32_C_SUFFIX__ U
#define __UINT32_FMTX__ "X"
#define __UINT32_FMTo__ "o"
#define __UINT32_FMTu__ "u"
#define __UINT32_FMTx__ "x"
#define __UINT32_MAX__ 4294967295U
#define __UINT32_TYPE__ unsigned int
#define __UINT64_C_SUFFIX__ ULL
#define __UINT64_FMTX__ "llX"
#define __UINT64_FMTo__ "llo"
#define __UINT64_FMTu__ "llu"
#define __UINT64_FMTx__ "llx"
#define __UINT64_MAX__ 18446744073709551615ULL
#define __UINT64_TYPE__ long long unsigned int
#define __UINT8_C_SUFFIX__
#define __UINT8_FMTX__ "hhX"
#define __UINT8_FMTo__ "hho"
#define __UINT8_FMTu__ "hhu"
#define __UINT8_FMTx__ "hhx"
#define __UINT8_MAX__ 255
#define __UINT8_TYPE__ unsigned char
#define __UINTMAX_C_SUFFIX__ UL
#define __UINTMAX_FMTX__ "lX"
#define __UINTMAX_FMTo__ "lo"
#define __UINTMAX_FMTu__ "lu"
#define __UINTMAX_FMTx__ "lx"
#define __UINTMAX_MAX__ 18446744073709551615UL
#define __UINTMAX_TYPE__ long unsigned int
#define __UINTMAX_WIDTH__ 64
#define __UINTPTR_FMTX__ "lX"
#define __UINTPTR_FMTo__ "lo"
#define __UINTPTR_FMTu__ "lu"
#define __UINTPTR_FMTx__ "lx"
#define __UINTPTR_MAX__ 18446744073709551615UL
#define __UINTPTR_TYPE__ long unsigned int
#define __UINTPTR_WIDTH__ 64
#define __UINT_FAST16_FMTX__ "hX"
#define __UINT_FAST16_FMTo__ "ho"
#define __UINT_FAST16_FMTu__ "hu"
#define __UINT_FAST16_FMTx__ "hx"
#define __UINT_FAST16_MAX__ 65535
#define __UINT_FAST16_TYPE__ unsigned short
#define __UINT_FAST32_FMTX__ "X"
#define __UINT_FAST32_FMTo__ "o"
#define __UINT_FAST32_FMTu__ "u"
#define __UINT_FAST32_FMTx__ "x"
#define __UINT_FAST32_MAX__ 4294967295U
#define __UINT_FAST32_TYPE__ unsigned int
#define __UINT_FAST64_FMTX__ "lX"
#define __UINT_FAST64_FMTo__ "lo"
#define __UINT_FAST64_FMTu__ "lu"
#define __UINT_FAST64_FMTx__ "lx"
#define __UINT_FAST64_MAX__ 18446744073709551615UL
#define __UINT_FAST64_TYPE__ long unsigned int
#define __UINT_FAST8_FMTX__ "hhX"
#define __UINT_FAST8_FMTo__ "hho"
#define __UINT_FAST8_FMTu__ "hhu"
#define __UINT_FAST8_FMTx__ "hhx"
#define __UINT_FAST8_MAX__ 255
#define __UINT_FAST8_TYPE__ unsigned char
#define __UINT_LEAST16_FMTX__ "hX"
#define __UINT_LEAST16_FMTo__ "ho"
#define __UINT_LEAST16_FMTu__ "hu"
#define __UINT_LEAST16_FMTx__ "hx"
#define __UINT_LEAST16_MAX__ 65535
#define __UINT_LEAST16_TYPE__ unsigned short
#define __UINT_LEAST32_FMTX__ "X"
#define __UINT_LEAST32_FMTo__ "o"
#define __UINT_LEAST32_FMTu__ "u"
#define __UINT_LEAST32_FMTx__ "x"
#define __UINT_LEAST32_MAX__ 4294967295U
#define __UINT_LEAST32_TYPE__ unsigned int
#define __UINT_LEAST64_FMTX__ "lX"
#define __UINT_LEAST64_FMTo__ "lo"
#define __UINT_LEAST64_FMTu__ "lu"
#define __UINT_LEAST64_FMTx__ "lx"
#define __UINT_LEAST64_MAX__ 18446744073709551615UL
#define __UINT_LEAST64_TYPE__ long unsigned int
#define __UINT_LEAST8_FMTX__ "hhX"
#define __UINT_LEAST8_FMTo__ "hho"
#define __UINT_LEAST8_FMTu__ "hhu"
#define __UINT_LEAST8_FMTx__ "hhx"
#define __UINT_LEAST8_MAX__ 255
#define __UINT_LEAST8_TYPE__ unsigned char
#define __USER_LABEL_PREFIX__ _
#define __VERSION__ "4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)"
#define __WCHAR_MAX__ 2147483647
#define __WCHAR_TYPE__ int
#define __WCHAR_WIDTH__ 32
#define __WINT_TYPE__ int
#define __WINT_WIDTH__ 32
#define __amd64 1
#define __amd64__ 1
#define __apple_build_version__ 8000042
#define __block __attribute__((__blocks__(byref)))
#define __clang__ 1
#define __clang_major__ 8
#define __clang_minor__ 0
#define __clang_patchlevel__ 0
#define __clang_version__ "8.0.0 (clang-800.0.42.1)"
#define __core2 1
#define __core2__ 1
#define __llvm__ 1
#define __nonnull _Nonnull
#define __null_unspecified _Null_unspecified
#define __nullable _Nullable
#define __pic__ 2
#define __strong
#define __tune_core2__ 1
#define __unsafe_unretained
#define __weak __attribute__((objc_gc(weak)))
#define __x86_64 1
#define __x86_64__ 1

gabyx · 2018-02-01T19:48:33Z

Try to fix it

acki-m · 2018-02-01T19:57:05Z

@gabyx
Take a look here:
https://github.com/rttrorg/rttr/blob/master/src/rttr/detail/base/core_prerequisites.h#L56

gabyx · 2018-02-01T20:01:23Z

But that only means we are on macOs, we can still use gcc there.
Committed and it seems to work on my 8.0.0 Apple Clang (at 27%)... see #100

-> 708e0fa

gabyx · 2018-02-01T20:13:49Z

is there an include <string> missing in

rttr/src/rttr/detail/misc/standard_types.cpp

Line 34 in 29e6ff9

That would explaing the strange compiler error (i dont get it, I mean why first at the end?) there are more accessing method("...", &std::string::length) ...

gabyx · 2018-02-01T20:21:04Z

@acki-m Could you give me access such that I can kill the travis builds for my PR...?

gabyx · 2018-02-01T20:23:56Z

@acki-m : Success full AppleClang build here on macOs 10.11.6 with AppleClang 8.0.0 (unit tests ok!)

acki-m · 2018-02-01T21:22:31Z

How can I give you access to travis builds? Didn't found anything.

error C2752: 'template_type_trait<std::array<bool, 100>>': more than one partial specialization matches the template argument list note: could be 'template_type_trait<T<N>>' note: or 'template_type_trait<T<N>>' Reported to MS

@gabyx

The error msg was: _Pragma ("clang diagnostic ignored \"-Wnoexcept-type\"") The version scheme for clang on MacOSX is different then for the other operating systems. The version prior clang 9 on mac did not support this pragma. So we disable it. thx to @gabyx

acki-m · 2018-02-02T20:30:46Z

@gabyx
I guess we finally might have something to merge

Good things come to those who wait.

gabyx · 2018-02-02T21:41:16Z

I merged your PR into mine: the only differences they have now is: mine builds everything on every platform -> because of different compiler warnings for benchmarks and tests.
and that I am using a different AppleClang #if...

gabyx · 2018-02-02T21:48:11Z

@acki-m: I think if you add me as a collaborator in your master repo. I will not push anything, you can also restrict that I think. Maybe then I have travis rights.. .-)

acki-m · 2018-02-03T13:36:11Z

@gabyx
You have got an invite 👋
We can have a clang comiler on apple platform, which has the normal LLVM version scheme?
Hallelujah, when will this finally end.

Another approach would be, generating these kind of check by cmake.
E.g. testing, whether the warning level works, then generating a header file with the #defines

Anyway, we should really come to an end here and finally merge the changes to master, so that we get something. No more big changes.
I could also make MSVC2017 compile, but that would require updating the dependencies.
What do you suggest should at least work now?

gabyx · 2018-02-03T15:32:50Z

For sure we should finish up, mine branch compiles too (travis sometimes just refuses to apt-get packages..., but its working as you can see)
Your are correct, you can build your own LLVM clang (the normal one, prefere this one) instead of the custom apple one.
I would recommend merging my branch, since its the very same as yours (sent you a PR https://github.com/acki-m/rttr/pull/1/files)
except it uses my set_warning_leve function which lets benchmarks compile too (see travis, they work, gcc4, )
MSVC2017 doesnt work, I did not see that, I dont care so much about MSVC (this compiler sucks anyway, do they now support all standart features, extended sfinae and so on, I dont know...)
We can still in a later step, when people want to use it in MSVC17, fix the MSVC builds...

Would you be happy with this? I think the changes in both PRs are perfect =)

acki-m · 2018-02-04T11:52:19Z

@gabyx
Can you disable the builds on travis now?

gabyx · 2018-02-04T16:14:35Z

on #100 : I am right now testing, if the os x build works, if so, I will rechange the order and it would be final for merging

acki-m · 2018-02-04T19:20:40Z

rejected PR, in favor of PR: #100

This was referenced Jan 23, 2018

Add -Wno-noexcept-type to disable warnings #105

Closed

clang 7.0 support - individual warning levels #100

Merged

acki-m added 2 commits January 24, 2018 10:07

fixed VS2013 build

26e3f6c

removed several FORCE_INLINE marks, due to errors reported from MSVC

02c7f37

e.g: "Warning C4714: function 'class rttr::type __thiscall rttr::detail::variant_sequential_view_private::get_rank_type(unsigned int)const ' marked as __forceinline"

acki-m added 4 commits January 24, 2018 16:19

made code compile also with c++11 flag

e0079ac

added clang 5.0.0 for linux travis builds

b389a01

updated MacOSX images to 9.3 & 8.3

fixed compile error for < c++17 compilers

5e91693

fixed compile error under linux, because of adjusted compiler version…

9dae7a3

… number

acki-m added 2 commits January 25, 2018 20:09

Merge branch 'master' into feature-add-cpp17-compiler-support

6ed9c1e

added missing EOL

7d0d8be

acki-m added 2 commits January 27, 2018 16:09

fixed detection of clang noexcept function signature

d7f3d57

* some clean up of the travis script (no more downloading of clang from llvm website)

fixed warning unused variable

6d9f8fe

private field 'm_value' is not used [-Werror,-Wunused-private-field]

acki-m added 2 commits January 29, 2018 23:56

used newest cmake release (3.10.2) for compiling @ travis

ba1b782

acki-m added 7 commits January 30, 2018 17:16

fixed visibility issue with gcc

33b1173

marked project as CXX

2ff1db4

so we can avoid initialization of the c compiler from cmake

added missing architecture x64 to valgrind build

f8cfde9

added function overload to select const/non const function with 'noexcept' specifier

added CXX to all projects - to avoid looking for C compiler

aac425a

fixed cmake warning (unused C flags)

c33b093

added 'linux-libc-dev:i386'

8e25084

Otherwise, we get following compile error: /usr/include/linux/errno.h:1:23: fatal error: asm/errno.h: No such file or directory #include <asm/errno.h>

typo in travis script

0e9a0c1

acki-m added 2 commits January 31, 2018 19:42

fixed cmake typo

dfb9e9c

fixed benchmark for rttr_cast

583b01c

added download of boost libraries for clang-4.0 build

acki-m added 2 commits January 31, 2018 22:30

fixed warning in test_classes.h

e831119

fixed MSVC build, when flag /:stdc++17 is used

b8dc30f

acki-m added 4 commits February 1, 2018 22:43

removed c++17 compilation for visual studio (compiler bug)

5843fa8

error C2752: 'template_type_trait<std::array<bool, 100>>': more than one partial specialization matches the template argument list note: could be 'template_type_trait<T<N>>' note: or 'template_type_trait<T<N>>' Reported to MS

fixed preprocessor error

082083c

try to fix compile error for clang-900.0.39.2 on apple

67d9920

acki-m closed this Feb 4, 2018

acki-m deleted the feature-add-cpp17-compiler-support branch March 5, 2018 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added support for c++17 compilers #107

added support for c++17 compilers #107

acki-m commented Jan 23, 2018

gabyx commented Jan 24, 2018

coveralls commented Jan 25, 2018 •

edited

Loading

gabyx commented Jan 25, 2018

gabyx commented Jan 25, 2018

acki-m commented Jan 27, 2018 •

edited

Loading

gabyx commented Jan 27, 2018 via email

gabyx commented Jan 29, 2018

gabyx commented Jan 29, 2018

gabyx commented Jan 31, 2018

acki-m commented Jan 31, 2018 •

edited

Loading

gabyx commented Feb 1, 2018 •

edited

Loading

gabyx commented Feb 1, 2018

gabyx commented Feb 1, 2018

acki-m commented Feb 1, 2018

gabyx commented Feb 1, 2018 •

edited

Loading

gabyx commented Feb 1, 2018 •

edited

Loading

gabyx commented Feb 1, 2018

gabyx commented Feb 1, 2018

acki-m commented Feb 1, 2018

acki-m commented Feb 2, 2018

gabyx commented Feb 2, 2018

gabyx commented Feb 2, 2018

acki-m commented Feb 3, 2018

gabyx commented Feb 3, 2018

acki-m commented Feb 4, 2018

gabyx commented Feb 4, 2018

acki-m commented Feb 4, 2018

added support for c++17 compilers #107

added support for c++17 compilers #107

Conversation

acki-m commented Jan 23, 2018

gabyx commented Jan 24, 2018

coveralls commented Jan 25, 2018 • edited Loading

gabyx commented Jan 25, 2018

gabyx commented Jan 25, 2018

acki-m commented Jan 27, 2018 • edited Loading

gabyx commented Jan 27, 2018 via email

gabyx commented Jan 29, 2018

gabyx commented Jan 29, 2018

gabyx commented Jan 31, 2018

acki-m commented Jan 31, 2018 • edited Loading

gabyx commented Feb 1, 2018 • edited Loading

gabyx commented Feb 1, 2018

gabyx commented Feb 1, 2018

acki-m commented Feb 1, 2018

gabyx commented Feb 1, 2018 • edited Loading

gabyx commented Feb 1, 2018 • edited Loading

gabyx commented Feb 1, 2018

gabyx commented Feb 1, 2018

acki-m commented Feb 1, 2018

acki-m commented Feb 2, 2018

gabyx commented Feb 2, 2018

gabyx commented Feb 2, 2018

acki-m commented Feb 3, 2018

gabyx commented Feb 3, 2018

acki-m commented Feb 4, 2018

gabyx commented Feb 4, 2018

acki-m commented Feb 4, 2018

coveralls commented Jan 25, 2018 •

edited

Loading

acki-m commented Jan 27, 2018 •

edited

Loading

acki-m commented Jan 31, 2018 •

edited

Loading

gabyx commented Feb 1, 2018 •

edited

Loading

gabyx commented Feb 1, 2018 •

edited

Loading

gabyx commented Feb 1, 2018 •

edited

Loading