Correct some offenses for RuboCop v1.56.0 #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
❯ bundle exec rubocop -A
Inspecting 280 files
.....................................................................................................................................C..................................................................................................................................................
Offenses:
lib/rubocop/cop/rspec/void_expect.rb:53:11: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
return true if parent.begin_type?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/rubocop/cop/rspec/void_expect.rb:54:11: C: [Corrected] Style/RedundantReturn: Redundant return detected.
return true if parent.block_type? && parent.body == expect
^^^^^^
280 files inspected, 2 offenses detected, 2 offenses corrected
```
5 tasks
bquorning
reviewed
Aug 9, 2023
| @@ -51,7 +51,8 @@ def void?(expect) | |||
| parent = expect.parent | |||
| return true unless parent | |||
| return true if parent.begin_type? | |||
| return true if parent.block_type? && parent.body == expect | |||
|
|
|||
| true if parent.block_type? && parent.body == expect | |||
There was a problem hiding this comment.
This could be simplified to
parent.block_type? && parent.body == expect(removing true if)
There was a problem hiding this comment.
Maybe, would it be good to have a cop to offense this?
There was a problem hiding this comment.
We can add support https://docs.rubocop.org/rubocop/cops_style.html#styleredundantconditional
7 tasks
ydah
added a commit
that referenced
this pull request
Oct 3, 2023
Follow up: #1692 (comment) ``` ❯ bundle exec rubocop -A Inspecting 291 files ...........................................................................................................................................C....................................................................................................................................................... Offenses: lib/rubocop/cop/rspec/void_expect.rb:55:11: C: [Corrected] Workit/RedundantBooleanConditional: This conditional expression can just be replaced by parent.block_type? && parent.body == expect. true if parent.block_type? && parent.body == expect ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 291 files inspected, 1 offense detected, 1 offense corrected ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1690 needs this PR's changes.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).