Follow up #1692

[ydah]

Follow up: #1692 (comment)

❯ bundle exec rubocop -A
Inspecting 291 files
...........................................................................................................................................C.......................................................................................................................................................

Offenses:

lib/rubocop/cop/rspec/void_expect.rb:55:11: C: [Corrected] Workit/RedundantBooleanConditional: This conditional expression can just be replaced by parent.block_type? && parent.body == expect.
          true if parent.block_type? && parent.body == expect
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

291 files inspected, 1 offense detected, 1 offense corrected

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• [-] Added tests.
• [-] Updated documentation.
• [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[ydah]

memo) I proposed improving cop to do this detection, but the merge was not done:

• Add support for Style/RedundantConditional when redundant returning of true/false only if/unless block rubocop#12176

[pirj]

Looks great!

I am sorry to hear about the cop. Sometimes it’s useful, like here.

[ydah]

The cop is in the following gem:

https://github.com/ydah/workitcop

This gem is placing some things that unfortunately we did not adopt for RuboCop's cop or some things that I personally use 👍