Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Replace Timeout.timeout in Net:HTTP#connect" #74

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Revert "Replace Timeout.timeout in Net:HTTP#connect" #74

merged 1 commit into from
Oct 21, 2022

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Oct 21, 2022

This reverts commit 753cae3.

We should handle connect_timeout and resolv_timeout with Socket.tcp. But...

  • Scocket.tcp does NOT support resolv_timeout yet. Because getaddrinfo_a support of Socket has been reverted.
  • The current implementation of Socket.tcp is abandoned by above revert related getaddrinfo_a. I'm not sure connect_timeout works correctly.

@hsbt hsbt merged commit 65aed40 into master Oct 21, 2022
@hsbt hsbt deleted the revert-10 branch October 21, 2022 12:39
@deivid-rodriguez deivid-rodriguez mentioned this pull request Nov 7, 2022
Open
This was referenced Feb 1, 2023
Merged
Merged
@johha johha mentioned this pull request Feb 7, 2023
Open
@mohamedhafez mohamedhafez mentioned this pull request Feb 8, 2023
Open
This was referenced Feb 14, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsbt @gamecreature