Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace Timeout.timeout with socket timeout" #51

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Feb 14, 2023

Reverts #21

Same reason with ruby/net-http#74

@tmtm
Copy link
Collaborator

tmtm commented Feb 14, 2023

LGTM! 👍
Currently, Timeout.timeout is running on one thread, so PR # 21 is solved.

@tmtm tmtm merged commit 9e44412 into master Feb 14, 2023
@tmtm tmtm deleted the revert-21-patch-1 branch February 14, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants