Give some source details on donations page across all donation types

[scooter-dangle]

Summary

Increase the usefulness of the Donations screen by including further information for all types of donation, not just donation site

Why

More useful for the banks to have specifics on the donations across types, rather than just donation sites.

Details

This screen (which you get to by clicking Donations | All Donations on the left hand menu) will be reworked as detailed below

The "Source" column will indicate Product Drive, Donation Site, Misc Donation or Manufacturer, corresponding to the "Source" dropdown on the new Donations page.

The "Donation Site" Column will be renamed to "Details", and will contain the following, dependent on the source.

For Product Drive, the details will be the product drive name
For Donation Site, the details will be the donation site name
For Manufacturer, the details will be the manufacturer name
For Misc Donations, the details will be the first 25 characters of the comment

#Note
This originally comes from a request in the HE slack " when you export the donations, and if it's a manufacturer, it's not exporting the name of the manufacturer field. Can you please add it."

Criteria for completion

• changes made to make the report work as described above
• supporting tests

[confused-cabbage]

I am interesting in trying to fix this issue !

[confused-cabbage]

Hi there - I am a little bit of a newbie, so I just want a little input to ensure I am doing this as you would like. the first two issues were easy:

• to change the source column to indicate Product Drive, Donation Site, Misc Donation, or Manufacturer I just changed the _donation_row.html.erb to render donation_row.source instead of donation_row.source-view.
• TO change the Donation Site Column to Details I just renamed the in the app/views/donations/index.html.erb file.

Do either of these changes require test updates? I am pretty new to reading some of these tests, and since I didn't make any changes to controller or model I wasn't sure what the protocol on this was.

Finally, I was wondering if you guys thought the best way to complete the last issue would be to just create logic in the _donation_row.html.erb partial that selectively renders what goes in the new Details based on the value in whatever donation_row.source that is being rendered into this partial, or whether the logic would live somewhere else.

Thanks for the input!

[dobosh28]

Hi, I'm friends with @lokisk1155. I can take over this issue!

[cielf]

Assigning this to @dobosh28

[github-actions]

This issue has been inactive for 262 hours (10.92 days) and will be automatically unassigned after 98 more hours (4.08 days).

[cielf]

Unassigning, as @dobosh has said they can't solve it.

[elasticspoon]

Howdy, I would like to give this a shot.

[cielf]

Go for it!

[elasticspoon]

There are some accessibility issues on the donations page. Would it be worth it for me to address them, either here or to open a new PR/issue for them?

[cielf]

New PR/issue please.

[github-actions]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

[github-actions]

Automatically unassigned after 7 days of inactivity.