Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bootstrap-select #3719

Closed
dorner opened this issue Jul 7, 2023 · 8 comments
Closed

Remove bootstrap-select #3719

dorner opened this issue Jul 7, 2023 · 8 comments
Assignees
@kristenking
Labels
Difficulty—Beginner Good First Issue Suitable for users that are newer or less experienced

Comments

@dorner
Copy link
Collaborator

dorner commented Jul 7, 2023

Summary

We have both bootstrap-select and select2 in our codebase. Both of them are only used a small number of times, but select2 is much more flexible and isn't tied to Bootstrap. We should replace the single usage of bootstrap-select (in the organization edit page) with select2, and remove bootstrap-select from the app.

Things to consider

No response

Criteria for Completion

No response
@dorner dorner added Good First Issue Suitable for users that are newer or less experienced Difficulty—Beginner labels Jul 7, 2023
@kristenking
Copy link
Contributor

kristenking commented Jul 9, 2023 •
edited
Loading

Hello @dorner! Could I work on this, please?

@awwaiid
Copy link
Collaborator

awwaiid commented Jul 9, 2023

@kristenking sure, go for it!

@kristenking
Copy link
Contributor

kristenking commented Jul 23, 2023 •
edited
Loading

here is the reference to PR connected to this issue #3763. Thank you a lot for your review!

@kristenking kristenking mentioned this issue Jul 24, 2023
Merged
@github-actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Aug 23, 2023
@kristenking
Copy link
Contributor

What I've Tried:

  • Added custom CSS in application.scss to override the default Select2 styles.
  • Played around with the inline styles directly in the Developer Tools.
  • Looked into our existing codebase to find any references to the usage of Select2 "multiple", but couldn't find any.

Problems Encountered:

  • The items chosen in the dropdown have a weird blue background and the delete ('x') icon overlaps with the text.
  • My custom styles are not reflecting any changes.

Request for Help:

I feel like I've hit a blocker and could use some additional perspectives on this issue. If anyone has experience styling Select2 dropdowns, your input would be greatly appreciated. Would love to pair up to solve this quicker if anyone is available.

@github-actions github-actions bot removed the stale label Aug 26, 2023
dorner pushed a commit that referenced this issue Sep 4, 2023
@kristenking
#3719 Remove bootstrap-select and replace with select2 (#3763)
fbadb55 
* change selectpicker to select2

* remove bootstrap-select gem

* update spect test to work with select2 dropdown

* remove bootstrap-select

* update select2 to multi-select

* fix formatting to pass rubocop

* Add styling for Select2 multiple selection
@isacben
Copy link

isacben commented Sep 16, 2023

I think this issue is solved. (?)

@kristenking
Copy link
Contributor

@dorner Any chance this issue can be closed as solved? Thank you @isacben and @dorner

@dorner
Copy link
Collaborator Author

dorner commented Sep 22, 2023

Yep, sorry! Thank you!

@dorner dorner closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristenking kristenking

Labels
Difficulty—Beginner Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@awwaiid @dorner @isacben @kristenking