-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3719 Remove bootstrap-select and replace with select2 #3763
#3719 Remove bootstrap-select and replace with select2 #3763
Conversation
It's definitely the right approach! I'm pretty sure we use select2 with multi-select successfully on other pages, so maybe check one of those to see how it's done? The UI definitely doesn't look great in that screenshot. |
What I've Tried:
Problems Encountered:
Request for Help: I feel like I've hit a blocker and could use some additional perspectives on this issue. If anyone has experience styling Select2 dropdowns, your input would be greatly appreciated. Would love to pair up to solve this quicker if anyone is available. |
I added these to
|
Thank you so much for your help @dorner ! My problem was silly but I am glad I found the issue: I was adding styling to application.scss under javascript folder not assets. This is how it looks now after adding styling: |
Nice, looks good! Thanks! |
Changes Made:
Screenshots:
Organization Edit Page with bootstrap-select:
Organization Edit Page with select2:
Tests:
Performed tests manually on the client side
Ran organization_system_spec.rb successfuly
Ran all rspec tests sucessfully
Notes and Questions:
I still need to improve UI in changed code. Should I add styles to the custom-select class or create a separate one for this dropdown? Alternatively, are there any out-of-the-box solutions that would work well here?
As it is the first time I work with this codebase, just wanted to ensure if I'm heading in the right direction. If there's a different approach that would be more suitable for this issue, please let me know, and I'll address it promptly.
Thank you a lot for your review!