Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Launching with the debugger does not work if there are disabled breakpoints #510

Closed
AlexMunro opened this issue Jul 17, 2019 · 12 comments · Fixed by #688
Closed

Launching with the debugger does not work if there are disabled breakpoints #510

AlexMunro opened this issue Jul 17, 2019 · 12 comments · Fixed by #688
Labels
need-more-info Awaiting information from author stale

Comments

@AlexMunro
Copy link

Your environment

  • vscode-ruby version: 0.24.1
  • Ruby version: 2.6.3p62
  • Ruby version manager (if any): asdf
  • VS Code version: 1.36.1
  • Operating System: MacOS Mojave 10.14.5
  • Using language server? (eg useLanguageServer is true?) No

Versions of possibly relevant gems (though updating didn't help in this case):
ruby-debug-ide version (0.6.0)
debase (0.2.3)
debase-ruby_core_source (0.10.5)

Expected behavior

After adding a breakpoint and disabling it, starting the debugger should work as normal, ignoring the disabled breakpoints.

Actual behavior

Leaving any disabled breakpoints in prevents the debugger from (properly?) starting. Nothing is written to the debug console, and in the case of the Rails server it does not respond to requests. However, the draggable debug toolbar does appear which responds to stop/restart and trying to launch twice gives the usual error message There is already a debug configuration <config name> running.

Enabling or removing the breakpoints and restarting allows the launch configurations to work as normal.

I've observed this behaviour with a Rails project (using the default configuration for launching rails servers) and a plain Ruby project (using the configuration listed here: https://github.com/rubyide/vscode-ruby/wiki/2.-Launching-from-VS-Code).

Obviously there's an easy workaround here, but it took a while to figure out this was the issue so it would be useful to have some kind of warning if a fix isn't feasible.

@griest024
Copy link

I have the same issue with a rack server. With logging enabled, the only message printed is Fast Debugger (ruby-debug-ide 0.7.0, debase 0.2.2, file filtering is supported) listens on 127.0.0.1:1234 and puma never launches.

@castwide
Copy link
Contributor

Same problem here. I just wanted to mention that launching with disabled breakpoints used to work, but I don't know exactly when it stopped.

@iggycoder
Copy link

Yep, same problem here.

@whitehorsesoft
Copy link

Problem still exists, extension 0.25.3, OSS code v 1.39.2, electron 4.2.12

@github-actions
Copy link

github-actions bot commented Aug 8, 2020

This issue has not had activity for 30 days. It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Aug 8, 2020
@AlexMunro
Copy link
Author

Still seeing this issue with debase 0.2.4.1, ruby-debug-ide 0.7.2, Ruby 2.7.1 and vscode-ruby 0.27.0.

@github-actions github-actions bot removed the stale label Aug 15, 2020
@github-actions
Copy link

This issue has not had activity for 30 days. It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Sep 14, 2020
@whitehorsesoft
Copy link

Planning on verifying once have time, to make sure this issue isn't closed inappropriately...

@github-actions github-actions bot removed the stale label Sep 15, 2020
@wingrunr21 wingrunr21 added the need-more-info Awaiting information from author label Sep 15, 2020
@lalunamel
Copy link

I'm definitely able to reproduce this issue locally with VS code.

I've filed an issue with them which is similar, but slightly different. (issue: #657)
In the case of the issue I've filed, it seems that ruby-debug-ide is closing and re-opening the connection to vscode over and over (tcp handshake -> [FIN ACK] is sent, another tcp handshake, etc)

In this case, though, I don't see that happening locally. Here's a screenshot of wireshark as I run rdebug-ide and connect with vscode while there is a single breakpoint that's disabled.

disabled-breakpoints-full

Here's a screenshot of the same thing, but with that breakpoint enabled. Notice that the highlighted packed contains the word start, which causes ruby-debug-ide to start the executable it's been given.

enabled-breakpoints-full

What's important here, though, is that VS code is not sending the start command when all breakpoints are disabled.

@github-actions
Copy link

This issue has not had activity for 30 days. It will be automatically closed in 7 days.

@brahn
Copy link

brahn commented Oct 26, 2020

Still seeing this:

  • vscode-ruby version: 0.27.0
  • Ruby version: ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-darwin19]
  • Ruby version manager (if any): rbenv
  • VS Code version: Version: 1.50.1
  • Operating System: MacOS Catalina 10.15.7
  • Gems of interest:
    • debase (0.2.4.1)
    • ruby-debug-ide (0.7.2)
    • solargraph (0.39.17)

@carsonreinke
Copy link

I am seeing this also, but noticed if sending SIGINT to the process it will no longer wait to launch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need-more-info Awaiting information from author stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants