fix: when a setBreakpoint request comes in, always respond only once #688
Conversation
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
======================================
Coverage 5.08% 5.08%
======================================
Files 10 10
Lines 118 118
Branches 20 20
======================================
Hits 6 6
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -50,7 +50,7 @@ export function spawn<T = string>( | |||
| if (typeof b === 'string') { | |||
| chunk = b.toString(); | |||
| } else { | |||
| chunk = b.toString(optsWithoutStdIn.encoding || 'utf8'); | |||
| chunk = b.toString(<BufferEncoding> optsWithoutStdIn.encoding || 'utf8'); | |||
There was a problem hiding this comment.
For some reason this code wouldn't typecheck / build w/o this cast.
|
@wingrunr21 Hello again friend! Fixing this bug would be really impactful for us at Stripe. Please let me know if there's anything I can do to make the review process easier for you. |
|
@wingrunr21 exciting! 🎉 do you have plans for a release w/ this fix anytime soon? looks like the last vscode-ruby release was in March or so. |
|
Yes, I'm doing a few dependency updates and will get it cut. Today/tomorrow. |
Description of change and why it was needed here
Fixes #510 and #657
This fixes a notorious bug that engineers at Stripe encounter daily: The debugger fails to attach because they have a breakpoint that is unset in a file.
Specifically, the situation occurs when VS Code has one file open that has all unset breakpoints (e.g., there are no active breakpoints in the file). It turns out that VS Code sends out a
setBreakpointsrequest with no breakpoints for this file. In this case, the Ruby debug adapter's code would not send a response to this request, so VS Code would wait forever for a response that would never come.I've updated the code to ensure that it always responds once to this sort of request, and fixes another bug where I think it might respond twice to a single setBreakpoints request.