Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk #5309

Merged

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Nov 20, 2024

Description

Allow only enabled destinations to be iterated in backendSubscriber.
Update Klaviyo bulk upload error handling

Linear Ticket

Resolves INT-2820

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.46%. Comparing base (1c78429) to head (7edb1ec).
Report is 1 commits behind head on release/1.38.x.

Files with missing lines Patch % Lines
...destinationmanager/klaviyobulkupload/apiService.go 57.14% 2 Missing and 1 partial ⚠️
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.38.x    #5309      +/-   ##
==================================================
- Coverage           73.47%   73.46%   -0.01%     
==================================================
  Files                 425      425              
  Lines               59965    59973       +8     
==================================================
+ Hits                44057    44058       +1     
- Misses              13435    13439       +4     
- Partials             2473     2476       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ItsSudip ItsSudip merged commit 8808245 into release/1.38.x Nov 20, 2024
59 of 60 checks passed
@ItsSudip ItsSudip deleted the fix.enabled.destinations.check.batch.router branch November 20, 2024 04:10
koladilip added a commit that referenced this pull request Dec 9, 2024
…5316)

* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: json marshal l errors when parsing poll response from klaviyo

* fix: payload size limit issue

* chore: add rate limiter in http client for Klaviyo Bulk Upload async destination (#5353)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk

* chore: add rate limited http client for klaviyo bulk

* refactor: add rate limiter klaviyo bulk upload

---------

Co-authored-by: Dilip Kola <kdilipkola@gmail.com>

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
mihir20 added a commit that referenced this pull request Dec 20, 2024
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
mihir20 pushed a commit that referenced this pull request Dec 20, 2024
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
(cherry picked from commit 98827e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants