fix: bing ads audience #5299
Merged
fix: bing ads audience #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix.integration_klaviyo_bingadsoc #5299 +/- ##
=====================================================================
- Coverage 73.40% 73.39% -0.01%
=====================================================================
Files 424 424
Lines 60243 59946 -297
=====================================================================
- Hits 44221 43998 -223
+ Misses 13578 13499 -79
- Partials 2444 2449 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
yashasvibajpai
approved these changes
Nov 18, 2024
shrouti1507
approved these changes
Nov 19, 2024
ItsSudip
changed the base branch from
release/1.38.x
to
fix.integration_klaviyo_bingadsoc
ItsSudip
merged commit 6d0a266
into
fix.integration_klaviyo_bingadsoc
59 of 60 checks passed
yashasvibajpai
added a commit
that referenced
this pull request
Nov 19, 2024
* fix: bing ads audience (#5299) * chore: handle 500kb limit, refactor to service impl (#5302) * chore: handle 500kb limit, refactor to service impl * chore: fix mock * chore: fix mock newline * chore: fix apiservice newline * chore: move error --------- Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
koladilip
added a commit
that referenced
this pull request
Dec 9, 2024
…5316) * fix: bq partitioning for additional columns (#5293) * chore: release 1.38.1 (#5295) * fix: klaviyo bulk upload and BingAds OC (#5305) * fix: bing ads audience (#5299) * chore: handle 500kb limit, refactor to service impl (#5302) * chore: handle 500kb limit, refactor to service impl * chore: fix mock * chore: fix mock newline * chore: fix apiservice newline * chore: move error --------- Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore: release 1.38.2 (#5306) * fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309) * chore: release 1.38.3 (#5311) * fix: json marshal l errors when parsing poll response from klaviyo * fix: payload size limit issue * chore: add rate limiter in http client for Klaviyo Bulk Upload async destination (#5353) * fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk * chore: add rate limited http client for klaviyo bulk * refactor: add rate limiter klaviyo bulk upload --------- Co-authored-by: Dilip Kola <kdilipkola@gmail.com> --------- Co-authored-by: Akash Chetty <achetty.iitr@gmail.com> Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
mihir20
added a commit
that referenced
this pull request
Dec 20, 2024
* fix: bq partitioning for additional columns (#5293) * chore: release 1.38.1 (#5295) * fix: klaviyo bulk upload and BingAds OC (#5305) * fix: bing ads audience (#5299) * chore: handle 500kb limit, refactor to service impl (#5302) * chore: handle 500kb limit, refactor to service impl * chore: fix mock * chore: fix mock newline * chore: fix apiservice newline * chore: move error --------- Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore: release 1.38.2 (#5306) * fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309) * chore: release 1.38.3 (#5311) * fix: disable vacuum at startup for reporting (#5325) * chore: remove full vacuum at flusher startup (#5332) * chore: release 1.38.4 (#5331) * update action to apidom-validate --------- Co-authored-by: Akash Chetty <achetty.iitr@gmail.com> Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com> Co-authored-by: mihir <mihir20121997@gmail.com>
mihir20
pushed a commit
that referenced
this pull request
Dec 20, 2024
* fix: bq partitioning for additional columns (#5293) * chore: release 1.38.1 (#5295) * fix: klaviyo bulk upload and BingAds OC (#5305) * fix: bing ads audience (#5299) * chore: handle 500kb limit, refactor to service impl (#5302) * chore: handle 500kb limit, refactor to service impl * chore: fix mock * chore: fix mock newline * chore: fix apiservice newline * chore: move error --------- Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore: release 1.38.2 (#5306) * fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309) * chore: release 1.38.3 (#5311) * fix: disable vacuum at startup for reporting (#5325) * chore: remove full vacuum at flusher startup (#5332) * chore: release 1.38.4 (#5331) * update action to apidom-validate --------- Co-authored-by: Akash Chetty <achetty.iitr@gmail.com> Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com> Co-authored-by: mihir <mihir20121997@gmail.com> (cherry picked from commit 98827e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this pr, we are trying to remove the discrepancy between server and integrations-info.
Linear Ticket
INT-2916
https://linear.app/rudderstack/issue/INT-2916/bing-ads-conversion-seems-like-the-bing-api-expects
Security