Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bq partitioning for additional columns #5293

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

achettyiitr
Copy link
Member

Description

  • BQ partitioning is used for additional columns like sent_at, timestamp, and original_timestamp.

Linear Ticket

  • Resolves PIPE-1731

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.27%. Comparing base (f070da1) to head (c824ea0).
Report is 1 commits behind head on release/1.38.x.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.38.x    #5293      +/-   ##
==================================================
- Coverage           73.28%   73.27%   -0.02%     
==================================================
  Files                 424      424              
  Lines               59946    59946              
==================================================
- Hits                43934    43927       -7     
- Misses              13552    13569      +17     
+ Partials             2460     2450      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit 4da3bf1 into release/1.38.x Nov 14, 2024
58 checks passed
@achettyiitr achettyiitr deleted the fix.bq-partitioning branch November 14, 2024 05:29
koladilip added a commit that referenced this pull request Dec 9, 2024
…5316)

* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: json marshal l errors when parsing poll response from klaviyo

* fix: payload size limit issue

* chore: add rate limiter in http client for Klaviyo Bulk Upload async destination (#5353)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk

* chore: add rate limited http client for klaviyo bulk

* refactor: add rate limiter klaviyo bulk upload

---------

Co-authored-by: Dilip Kola <kdilipkola@gmail.com>

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
mihir20 added a commit that referenced this pull request Dec 20, 2024
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
mihir20 pushed a commit that referenced this pull request Dec 20, 2024
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
(cherry picked from commit 98827e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants