Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync release v1.38.2 to main branch #5308

Merged

Conversation

devops-github-rudderstack
Copy link
Collaborator

Description

Syncing patch release v1.38.2 to main branch

↓↓ Please review and edit commit overrides before merging ↓↓

BEGIN_COMMIT_OVERRIDE
fix: bq partitioning for additional columns (#5293)
fix: klaviyo bulk upload and BingAds OC (#5305)
END_COMMIT_OVERRIDE

achettyiitr and others added 4 commits November 14, 2024 10:59
* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 36.55172% with 92 lines in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (7aa1895) to head (80ad8bc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...destinationmanager/klaviyobulkupload/apiService.go 12.76% 82 Missing ⚠️
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 80.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5308      +/-   ##
==========================================
+ Coverage   73.30%   73.51%   +0.20%     
==========================================
  Files         423      424       +1     
  Lines       59908    59927      +19     
==========================================
+ Hits        43917    44055     +138     
+ Misses      13534    13408     -126     
- Partials     2457     2464       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Sidddddarth Sidddddarth enabled auto-merge (squash) November 19, 2024 10:45
@Sidddddarth Sidddddarth merged commit 86b333c into master Nov 19, 2024
55 checks passed
@Sidddddarth Sidddddarth deleted the sync-release-1c784292730c6cd9008def40ec1464866bf56848 branch November 19, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants