Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable vacuum at startup for reporting #5325

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Nov 27, 2024

Description

  • Added flag for conditionally running vacuuming for reporting and error reporting at startup.

Linear Ticket

Ref PIPE-1748

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.55%. Comparing base (e4cb7f1) to head (a2152a3).
Report is 1 commits behind head on release/1.38.x.

Files with missing lines Patch % Lines
enterprise/reporting/error_reporting.go 0.00% 7 Missing ⚠️
enterprise/reporting/reporting.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.38.x    #5325      +/-   ##
==================================================
+ Coverage           73.43%   73.55%   +0.11%     
==================================================
  Files                 425      425              
  Lines               59973    59975       +2     
==================================================
+ Hits                44044    44113      +69     
+ Misses              13450    13393      -57     
+ Partials             2479     2469      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr deleted the fix.disable-vacuum-at-startup branch November 29, 2024 02:55
@mihir20 mihir20 restored the fix.disable-vacuum-at-startup branch December 2, 2024 09:44
@mihir20 mihir20 reopened this Dec 2, 2024
@mihir20 mihir20 marked this pull request as ready for review December 2, 2024 09:45
@mihir20 mihir20 merged commit d8fb8be into release/1.38.x Dec 2, 2024
115 of 118 checks passed
@mihir20 mihir20 deleted the fix.disable-vacuum-at-startup branch December 2, 2024 11:12
mihir20 added a commit that referenced this pull request Dec 20, 2024
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
mihir20 pushed a commit that referenced this pull request Dec 20, 2024
* fix: bq partitioning for additional columns (#5293)

* chore: release 1.38.1 (#5295)

* fix: klaviyo bulk upload and BingAds OC  (#5305)

* fix: bing ads audience (#5299)

* chore: handle 500kb limit, refactor to service impl (#5302)

* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error

---------

Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>

* chore: release 1.38.2 (#5306)

* fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)

* chore: release 1.38.3 (#5311)

* fix: disable vacuum at startup for reporting (#5325)

* chore: remove full vacuum at flusher startup (#5332)

* chore: release 1.38.4 (#5331)

* update action to apidom-validate

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com>
Co-authored-by: mihir <mihir20121997@gmail.com>
(cherry picked from commit 98827e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants