feat: Download terraform versions using `>=` and `~>` specifiers #1776

fblgit · 2021-08-27T23:10:15Z

Implements tfswitch libs and semver to parse properly the terraform files version, then compares against the available terraform releases and returns version.Version object with the right value.

This is the first PR, let me know if I'm missing something here.

Libraries

Closes

Closes Specified terraform version (using required_version) not used when required_providers is specified #1153
Closes Atlantis doesn't detect terraform version #1747
Closes Allow additional specifiers in terraform's required_version other than = e.g. ~> and > #1217

fblgit · 2021-08-28T08:59:41Z

?   	github.com/runatlantis/atlantis	[no test files]
ok  	github.com/runatlantis/atlantis/cmd	(cached)
ok  	github.com/runatlantis/atlantis/server	(cached)
ok  	github.com/runatlantis/atlantis/server/controllers	(cached)
ok  	github.com/runatlantis/atlantis/server/controllers/events	(cached)
?   	github.com/runatlantis/atlantis/server/controllers/templates	[no test files]
ok  	github.com/runatlantis/atlantis/server/core/db	(cached)
ok  	github.com/runatlantis/atlantis/server/core/locking	(cached)
ok  	github.com/runatlantis/atlantis/server/core/runtime	(cached)
ok  	github.com/runatlantis/atlantis/server/core/runtime/cache	(cached)
?   	github.com/runatlantis/atlantis/server/core/runtime/models	[no test files]
ok  	github.com/runatlantis/atlantis/server/core/runtime/policy	(cached)
ok  	github.com/runatlantis/atlantis/server/core/terraform	(cached)
ok  	github.com/runatlantis/atlantis/server/events	1.760s
?   	github.com/runatlantis/atlantis/server/events/matchers	[no test files]
ok  	github.com/runatlantis/atlantis/server/events/models	(cached)
?   	github.com/runatlantis/atlantis/server/events/models/fixtures	[no test files]
ok  	github.com/runatlantis/atlantis/server/events/runtime/common	(cached)
ok  	github.com/runatlantis/atlantis/server/events/vcs	(cached)
ok  	github.com/runatlantis/atlantis/server/events/vcs/bitbucketcloud	(cached)
ok  	github.com/runatlantis/atlantis/server/events/vcs/bitbucketserver	(cached)
ok  	github.com/runatlantis/atlantis/server/events/vcs/common	(cached)
?   	github.com/runatlantis/atlantis/server/events/vcs/fixtures	[no test files]
ok  	github.com/runatlantis/atlantis/server/events/webhooks	(cached)
ok  	github.com/runatlantis/atlantis/server/events/yaml	(cached)
ok  	github.com/runatlantis/atlantis/server/events/yaml/raw	(cached)
ok  	github.com/runatlantis/atlantis/server/events/yaml/valid	(cached)
ok  	github.com/runatlantis/atlantis/server/logging	(cached)
ok  	github.com/runatlantis/atlantis/server/recovery	(cached) [no tests to run]
?   	github.com/runatlantis/atlantis/testdrive	[no test files]

Tests looking good, but in the way it is.. it will require to keep up-to-date these tests as the latest version of terraform may get updated at some point then instead of 1.0.5 probably it will return at some point 1.1.0 which I think is the one in progress

server/events/project_command_context_builder.go

jamengual · 2022-05-13T21:54:01Z

@fblgit any updates on this? Thanks for the contribution

mustafa89 · 2022-06-12T18:47:49Z

are there any updates for this?

jamengual · 2022-07-07T20:48:43Z

No activity for more than 30 days. closing

pszypowicz · 2022-10-13T09:52:55Z

Can I help with this PR? This seems to be almost finished and would bring great value.

nitrocode · 2022-11-10T02:01:15Z

@fblgit @pszypowicz yes please feel free to take over if you think this PR has value.

nitrocode · 2022-11-20T23:45:28Z

@fblgit @pszypowicz i went ahead and fixed the conflicts in case anyone would like to take over by branching off this branch or updating the existing one

server/events/project_command_builder_test.go

llamahunter · 2022-12-05T18:00:10Z

thank you!!

grimm26 · 2022-12-07T14:05:37Z

I assume terraform_version in atlantis.yaml takes precedent?

nitrocode · 2022-12-07T16:01:56Z

This should only affect tf root modules with required_version set

grimm26 · 2022-12-07T16:42:42Z

I have required_version set in my terraform config but I also specify terraform_version in my atlantis.yaml.

nitrocode · 2022-12-07T17:42:58Z

Unsure how it will interact. Please let us know and help contribute docs for the website. We want to make sure everything is as clear as possible.

grimm26 · 2022-12-07T18:48:46Z

I just did a test with required_version = "~> 1.2" in my terraform config and terraform_version: v1.2.5 in my atlantis.yaml and it ran with terraform v.1.2.5, so it seems that a required_version specified in atlantis.yaml takes precedent, which is what makes sense. I'll look for where to notate this in the docs.

…#1776) * Refactor TFVersion from Dir with tfswitch lib * Added tests and cleaned up code * linted fmtd * fixed conflict go.mod * bumped to tf1.0.6 * bumped go.mod * Update project_command_context_builder.go * Bump warrensbox/terraform-switcher * Fix tests * rm redundant mocks library import Co-authored-by: xmurias <xmurias@gmail.com> Co-authored-by: Xavier <77047592+xavipanda@users.noreply.github.com> Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>

Refactor TFVersion from Dir with tfswitch lib

39cdba5

fblgit requested a review from a team as a code owner August 27, 2021 23:10

Added tests and cleaned up code

a023dcf

linted fmtd

f422681

This was referenced Aug 28, 2021

Atlantis ignoring terraform config version #1360

Closed

Terraform version in atlantis.yaml is ignored #1598

Closed

fblgit and others added 5 commits September 4, 2021 02:14

Merge branch 'master' into autoversion_fix

9b2ede9

fixed conflict go.mod

43e9756

bumped to tf1.0.6

efbfe36

Merge branch 'master' into autoversion_fix

18b4ba2

bumped go.mod

6920ff2

contil reviewed Sep 23, 2021

View reviewed changes

server/events/project_command_context_builder.go Show resolved Hide resolved

chenrui333 changed the title ~~Refactor TFVersion from Dir with tfswitch lib~~ refactor: TFVersion from Dir with tfswitch lib Nov 20, 2021

jamengual added feature New functionality/enhancement waiting-on-response Waiting for a response from the user labels May 13, 2022

jamengual closed this Jul 7, 2022

nitrocode reopened this Nov 10, 2022

Merge branch 'main' into autoversion_fix

c905d79

nitrocode added 4 commits November 20, 2022 17:55

Update project_command_context_builder.go

54e0598

Bump warrensbox/terraform-switcher

b077520

Fix tests

cda963c

rm redundant mocks library import

8671a69

nitrocode force-pushed the autoversion_fix branch from cd65563 to 8671a69 Compare November 21, 2022 02:15

nitrocode approved these changes Nov 21, 2022

View reviewed changes

nitrocode changed the title ~~refactor: TFVersion from Dir with tfswitch lib~~ Detect terraform versions using >= and ~> specifiers Nov 21, 2022

jamengual reviewed Nov 21, 2022

View reviewed changes

server/events/project_command_builder_test.go Show resolved Hide resolved

jamengual approved these changes Nov 21, 2022

View reviewed changes

nitrocode merged commit f8b1ea9 into runatlantis:main Nov 21, 2022

This was referenced Nov 21, 2022

v0.21+: Override mirror URL for terraform downloads #2701

Closed

Reduce image size by rm'ing old tf versions #2619

Merged

grimm26 mentioned this pull request Dec 7, 2022

docs: terraform version usage after allowing additional required_version specifiers #2760

Merged

nitrocode mentioned this pull request Dec 16, 2022

v0.21+: Pessimistic operator ~> for Terraform version detection not working as expected #2806

Closed

nitrocode added this to the 0.21.0 milestone Jan 13, 2023

nitrocode changed the title ~~Detect terraform versions using >= and ~> specifiers~~ feat: Download terraform versions using >= and ~> specifiers Jan 25, 2023

nitrocode mentioned this pull request Sep 5, 2023

Support OpenTofu (epic) #3741

Open

1 task

nitrocode mentioned this pull request Mar 11, 2024

Support OpenTofu auto download #4339

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Download terraform versions using `>=` and `~>` specifiers #1776

feat: Download terraform versions using `>=` and `~>` specifiers #1776

fblgit commented Aug 27, 2021 •

edited by nitrocode

Loading

fblgit commented Aug 28, 2021

jamengual commented May 13, 2022

mustafa89 commented Jun 12, 2022

jamengual commented Jul 7, 2022

pszypowicz commented Oct 13, 2022

nitrocode commented Nov 10, 2022

nitrocode commented Nov 20, 2022

llamahunter commented Dec 5, 2022

grimm26 commented Dec 7, 2022 •

edited

Loading

nitrocode commented Dec 7, 2022

grimm26 commented Dec 7, 2022

nitrocode commented Dec 7, 2022

grimm26 commented Dec 7, 2022

feat: Download terraform versions using >= and ~> specifiers #1776

feat: Download terraform versions using >= and ~> specifiers #1776

Conversation

fblgit commented Aug 27, 2021 • edited by nitrocode Loading

fblgit commented Aug 28, 2021

jamengual commented May 13, 2022

mustafa89 commented Jun 12, 2022

jamengual commented Jul 7, 2022

pszypowicz commented Oct 13, 2022

nitrocode commented Nov 10, 2022

nitrocode commented Nov 20, 2022

llamahunter commented Dec 5, 2022

grimm26 commented Dec 7, 2022 • edited Loading

nitrocode commented Dec 7, 2022

grimm26 commented Dec 7, 2022

nitrocode commented Dec 7, 2022

grimm26 commented Dec 7, 2022

feat: Download terraform versions using `>=` and `~>` specifiers #1776

feat: Download terraform versions using `>=` and `~>` specifiers #1776

fblgit commented Aug 27, 2021 •

edited by nitrocode

Loading

grimm26 commented Dec 7, 2022 •

edited

Loading