Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: terraform version usage after allowing additional required_version specifiers #2760

Merged
merged 2 commits into from
Dec 11, 2022

Conversation

grimm26
Copy link
Contributor

@grimm26 grimm26 commented Dec 7, 2022

what

  • Add docs on terraform version constaints and specifiers

why

  • Clarify the docs about setting the terraform version, especially since v0.21.0

references

@grimm26 grimm26 requested a review from a team as a code owner December 7, 2022 20:08
@grimm26
Copy link
Contributor Author

grimm26 commented Dec 7, 2022

companion to #1776

@jamengual jamengual added the docs Documentation label Dec 7, 2022
@nitrocode nitrocode changed the title Clarify the docs about setting the terraform version, especially since v0.21.0 docs: terraform version usage after allowing additional required_version specifiers Dec 7, 2022
@nitrocode
Copy link
Member

Hi @grimm26. Thank you for the PR. Our docs need more love so this is great.

Please use the PR template in the future. I filled it out to keep things consistent.

I added a few comments for further improvements.

@grimm26
Copy link
Contributor Author

grimm26 commented Dec 10, 2022

@nitrocode sorry for the delay, I was out of town. I added another commit with improvements.

@nitrocode nitrocode merged commit 8557172 into runatlantis:main Dec 11, 2022
@nitrocode
Copy link
Member

Thank you very much @grimm26 ! Please feel free to update more of the docs (or code) when you see issues.

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
…sion` specifiers (runatlantis#2760)

* Clarify the docs about setting the terraform version, especially since
v0.21.0

* Address comments about adding further detail and examples

Also updated versions mentioned to be more recent.
@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants