-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): website: upgrade vuepress 0.x to 1.x #2828
Conversation
8c86817
to
29d63c9
Compare
ga: "UA-6850151-3", | ||
plugins: [ | ||
['@vuepress/google-analytics', { ga: "UA-6850151-3", }] | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// https://vuepress.vuejs.org/theme/inheritance.html#usage | ||
module.exports = { | ||
extend: '@vuepress/theme-default' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before setting this, CustomHome doesn't show navbar. So add this setting and mv components/CustomHome.vue
into theme/components/Home.vue
$homeWidth = 960px | ||
$buttonColor = #34be68 | ||
$darkBackground = rgb(250, 250, 250) | ||
.container | ||
padding-top 3.6rem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://app.netlify.com/sites/runatlantis/deploys/63a047b25b06910008582742 .node-version is available. https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript |
@@ -0,0 +1 @@ | |||
14.21.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump this to node 16.x since that's the latest lts? Or should we do that in a separate pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we can bump it in a separate PR and check with netlify deployment.
This is great. Nice work! I think we can wait on upgrading to vue 2.x until it's out of beta. @runatlantis/maintainers i clicked around on the preview website and it looks pretty good. Please take a second look. |
Thanks @krrrr38! |
what
why
Currently, we use vuepress 0.x.
discussion
references