Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): website: upgrade vuepress 0.x to 1.x #2828

Merged
merged 2 commits into from
Dec 19, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,5 @@ end-to-end-deps: ## Install e2e dependencies
end-to-end-tests: ## Run e2e tests
./scripts/e2e.sh

website-dev:
website-dev: ## Run runatlantic.io on localhost:8080
yarn website:dev
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"devDependencies": {
"vuepress": "^0.14.2"
"@vuepress/plugin-google-analytics": "^1.9.7",
"vuepress": "^1.9.7"
},
"scripts": {
"website:dev": "vuepress dev runatlantis.io",
Expand Down
4 changes: 3 additions & 1 deletion runatlantis.io/.vuepress/config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
module.exports = {
title: 'Atlantis',
description: 'Atlantis: Terraform Pull Request Automation',
ga: "UA-6850151-3",
plugins: [
['@vuepress/google-analytics', { ga: "UA-6850151-3", }]
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

head: [
['link', { rel: 'icon', type: 'image/png', href: '/favicon-196x196.png', sizes: '196x196' }],
['link', { rel: 'icon', type: 'image/png', href: '/favicon-96x96.png', sizes: '96x96' }],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,11 @@
$MQMobile = 719px
$MQMobileNarrow = 419px

@import '~@temp/override.styl' // generated from user config

$homeWidth = 960px
$buttonColor = #34be68
$darkBackground = rgb(250, 250, 250)
.container
padding-top 3.6rem
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom-layout is disappeared. So add padding-top into Home.vue container for navbar.

image

.home
padding 0 2rem
max-width $homeWidth
Expand Down
6 changes: 6 additions & 0 deletions runatlantis.io/.vuepress/theme/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// introduce custom home with navbar
// https://stackoverflow.com/a/60220684
// https://vuepress.vuejs.org/theme/inheritance.html#usage
module.exports = {
extend: '@vuepress/theme-default'
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before setting this, CustomHome doesn't show navbar. So add this setting and mv components/CustomHome.vue into theme/components/Home.vue

2 changes: 1 addition & 1 deletion runatlantis.io/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
layout: HomeCustom
home: true
pageClass: home-custom
heroImage: /hero.png
heroText: Atlantis
Expand Down
9,371 changes: 5,874 additions & 3,497 deletions yarn.lock

Large diffs are not rendered by default.