fix: dont set commit status for old commits to new pipelines #4784
+87
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitz7
requested review from
chenrui333,
lukemassa and
nitrocode
and removed request for
a team
lukemassa
previously approved these changes
Aug 8, 2024
|
thanks @lukemassa @chenrui333 ! I had to fix a few conflicts, but all good now |
|
Somewhat related: |
|
Ah yes, similar... hmm let me compare this to what my PR is doing. |
|
Ok they are pretty much the same, except that this one will return earlier which is probably better than looping for longer and defaulting to setting |
X-Guardian
added
the
duplicate
|
Superseded by #5033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Stop Atlantis from updating the status of the wrong commit in GitLab
why
In Gitlab when a new commit was pushed while Atlantis was still running on a previous commit Atlantis would update the status of the wrong commit. This sometimes lead to merge requests not being mergeable by Atlantis as some of the statuses would be incorrect.
These changes prevent Atlantis from updating the status by returning early when
mr.HeadPipeline.SHA != pull.HeadCommittests
We've been running our own Atlantis with these changes for about a month. Have also included a test to ensure that the update status request is never made