-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change GitLab UpdateStatus
Function to get Pipeline from Commit rather than the Merge Request
#5033
fix: Change GitLab UpdateStatus
Function to get Pipeline from Commit rather than the Merge Request
#5033
Conversation
Signed-off-by: X-Guardian <simonheather99@gmail.com>
0940225
to
a54768a
Compare
@lukemassa do you have time to take a look? |
Once the container image has finished building from this PR, I will test it further on my company's non-prod Atlantis instance. |
did you have a chance to test this? |
Apparently publishing dev images from PR commits has been disabled, so I can't test until it is merged and a dev image is published. |
what
Change the GitLab Client
UpdateStatus
function to get the pipeline ID from the commit that was used to trigger the Atlantis run, rather than the head pipeline of the Merge Request.why
tests
Tested locally and unit tests updated
I also refactored all the GitLab Client Update Status tests to use proper JSON handling.
References