Clarifications and consistent use of quotation marks #1992
Conversation
|
Hey @sebras ! Thanks for this PR, and sorry it took me so long to get to it. The golden rule with PRs is basically to keep things to one logical change per PR. So while doing this isn't bad per-se, it makes it harder to merge. If you had one PR with the quotes, and then either one PR with all of the other changes, or even one PR per change, that'd be easier to get through, because you can tackle the work in bits. I think using the "s makes sense for "hello world" here, but I'd like @carols10cents 's input. For the other changes, some of them I think are good, some of them I'm not sure on. Carol, could you maybe review this and then I can accept or reject whatever we agree upon? |
|
Thanks! I love making the quotation marks more consistent. I also like the commit that makes our use of the word "element" clearer; I don't know what we were thinking there 😅 I do think there are two further improvements to be made here though:
I would prefer to remove "should" here, it sounds too much like "maybe it won't, sometimes the installer is flaky" which isn't what we want to convey. So I think this should read:
In this part:
I'm now thinking it should be "indices"? So:
Or else singular "its" instead of "their":
I'm not sure why the addition of "respective" is making my brain have a problem with the singular/plural parts. wdyt @steveklabnik ? All the other changes are fine with me. I agree with @steveklabnik that these would have been better as multiple PRs. No problem for this time though :) |
|
Nope, I agree 100%: I'd say it should be "indicies", though it is plural, so "their". @sebras mind making these changes? Thanks! |
I know that having logical changes split up into separate commits eases reviews. I'll update the PR shortly. |
Especially the word "other" in this sentence is unclear, "other" than what/which?
It's all good! In something like a book, wording change are "logical" changes, which is a bit strange. As we said, it's no big deal though :) We have had some huge PRs with tons of small changes where we wanted some, but not all, and that was tricky. |
No worries at all. I'll try to remember next time I contribute. :)
You tricked me a bit here! :) Supposedly the word is "indices" without the last "i". Ispell detected the new typo in Travis CI, I fix... |
Update cargo, books. ## cargo 8 commits in 3ba5f27170db10af7a92f2b682e049397197b8fa..5da4b4d47963868d9878480197581ccbbdaece74 2019-10-22 15:05:18 +0000 to 2019-10-28 21:53:41 +0000 - Add --filter-platform to `cargo metadata`. (rust-lang/cargo#7376) - Fix `cargo fix` not showing colors. (rust-lang/cargo#7550) - Rephrase --manifest-path section (rust-lang/cargo#7409) - Add a note to discourage the use of -Zminimal-versions. (rust-lang/cargo#7549) - Fix profile override warning in a workspace. (rust-lang/cargo#7536) - Fix some tests failing on Windows nightly. (rust-lang/cargo#7534) - Show better error message for Windows abnormal termination. (rust-lang/cargo#7535) - Run `apt update` before `apt install` (rust-lang/cargo#7541) ## reference 8 commits in 5b9d2fc..4b21b64 2019-10-03 22:39:10 +0200 to 2019-10-27 22:33:11 +0100 - Document `const_constructor` feature (rust-lang/reference#677) - Add `non_exhaustive` to reference. (rust-lang/reference#609) - Re-add rust-docs component for lintcheck (rust-lang/reference#702) - group signed and unsigned integers in layout table (rust-lang/reference#700) - Fix layout table rendering (rust-lang/reference#699) - Add reference for attributes in function parameters (rust-lang/reference#657) - Update now that proc macros can expand to macro_rules. (rust-lang/reference#694) - Fix match in union example. (rust-lang/reference#684) ## book 8 commits in 9bb8b161963fcebc9d9ccd732ba26f42108016d5..28fa3d15b0bc67ea5e79eeff2198e4277fc61baf 2019-10-14 18:42:55 -0500 to 2019-10-29 07:16:09 -0500 - Update Ch19.1 on slice splitting (rust-lang/book#1999) - fixed inconsistent terminology regarding enums (rust-lang/book#2022) - Update ch15-03 code to match output. (rust-lang/book#2020) - Fixes rust-lang/book#2039 (rust-lang/book#2040) - Update ch15-03-drop.md (rust-lang/book#2049) - unit type value is also a value (rust-lang/book#2061) - Minor: remove an extraneous `.` (rust-lang/book#2059) - Clarifications and consistent use of quotation marks (rust-lang/book#1992) ## rust-by-example 4 commits in 0b111eaae36cc4b4997684be853882a59e2c7ca7..f3197ddf2abab9abdbc029def8164f4a748b0d91 2019-10-14 18:34:25 -0300 to 2019-10-29 10:17:40 -0300 - Fix typos (rust-lang/rust-by-example#1285) - Improve Cargo / Dependencies section (rust-lang/rust-by-example#1287) - Improve Cargo / Build Scripts section (rust-lang/rust-by-example#1288) - Make if_let exercise runnable (rust-lang/rust-by-example#1289)
While translating the book to Swedish I stumbled upon a few places where it was less straightforward to translate. I looked at the original English text and felt that perhaps the original can be improved a bit. These are my suggestions.
I found that sometimes quotation marks were used around “Hello, world!”-program, but sometimes they were missing, like so: Hello, world! program. I think it may be easier to read when quotation marks are used consistently. Since I'm not translating any of the program code or strings it prints, it also make more sense this way in Swedish.
This is my first real contribution back to
rust-lang/book, so if I some how prepared these commits incorrectly, let me know and I'll try to address this.