Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ch15-03-drop.md #2049

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Update ch15-03-drop.md #2049

merged 2 commits into from
Oct 24, 2019

Conversation

DieBauer
Copy link
Contributor

@DieBauer DieBauer commented Aug 6, 2019

No description provided.

@eddyp
Copy link
Contributor

eddyp commented Aug 29, 2019

Definitely no. The proposed phrasing is confusing/incorrect.

If it's more clear, you can read as "so that" instead of "so"

@DieBauer
Copy link
Contributor Author

DieBauer commented Sep 4, 2019

@eddyp I agree. I propose to add a comma, to make the sentence more clear.

steveklabnik
steveklabnik reviewed Sep 15, 2019
View reviewed changes
src/ch15-03-drop.md Outdated Show resolved Hide resolved
steveklabnik
steveklabnik suggested changes Sep 15, 2019
View reviewed changes
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you're right that this is unclear, but I prefer my suggestion. If you apply it, I'm happy to merge this PR!

@DieBauer @steveklabnik
Update src/ch15-03-drop.md
7882e24 
Co-Authored-By: Steve Klabnik <steve@steveklabnik.com>
@DieBauer
Copy link
Contributor Author

Thanks for your feedback. Suggestion is applied :)

steveklabnik
steveklabnik approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@steveklabnik steveklabnik merged commit 67c5a6e into rust-lang:master Oct 24, 2019
@ehuss ehuss mentioned this pull request Oct 29, 2019
Merged
bors added a commit to rust-lang/rust that referenced this pull request Oct 30, 2019
@bors
Auto merge of #65941 - ehuss:update-cargo-books, r=alexcrichton
c553e8e 
Update cargo, books.

## cargo

8 commits in 3ba5f27170db10af7a92f2b682e049397197b8fa..5da4b4d47963868d9878480197581ccbbdaece74
2019-10-22 15:05:18 +0000 to 2019-10-28 21:53:41 +0000
- Add --filter-platform to `cargo metadata`. (rust-lang/cargo#7376)
- Fix `cargo fix` not showing colors. (rust-lang/cargo#7550)
- Rephrase --manifest-path section (rust-lang/cargo#7409)
- Add a note to discourage the use of -Zminimal-versions. (rust-lang/cargo#7549)
- Fix profile override warning in a workspace. (rust-lang/cargo#7536)
- Fix some tests failing on Windows nightly. (rust-lang/cargo#7534)
- Show better error message for Windows abnormal termination. (rust-lang/cargo#7535)
- Run `apt update` before `apt install` (rust-lang/cargo#7541)

## reference

8 commits in 5b9d2fc..4b21b64
2019-10-03 22:39:10 +0200 to 2019-10-27 22:33:11 +0100
- Document `const_constructor` feature (rust-lang/reference#677)
- Add `non_exhaustive` to reference. (rust-lang/reference#609)
- Re-add rust-docs component for lintcheck (rust-lang/reference#702)
- group signed and unsigned integers in layout table (rust-lang/reference#700)
- Fix layout table rendering (rust-lang/reference#699)
- Add reference for attributes in function parameters (rust-lang/reference#657)
- Update now that proc macros can expand to macro_rules. (rust-lang/reference#694)
- Fix match in union example. (rust-lang/reference#684)

## book

8 commits in 9bb8b161963fcebc9d9ccd732ba26f42108016d5..28fa3d15b0bc67ea5e79eeff2198e4277fc61baf
2019-10-14 18:42:55 -0500 to 2019-10-29 07:16:09 -0500
- Update Ch19.1 on slice splitting (rust-lang/book#1999)
- fixed inconsistent terminology regarding enums (rust-lang/book#2022)
- Update ch15-03 code to match output. (rust-lang/book#2020)
- Fixes rust-lang/book#2039 (rust-lang/book#2040)
- Update ch15-03-drop.md (rust-lang/book#2049)
- unit type value is also a value (rust-lang/book#2061)
- Minor: remove an extraneous `.` (rust-lang/book#2059)
- Clarifications and consistent use of quotation marks (rust-lang/book#1992)

## rust-by-example

4 commits in 0b111eaae36cc4b4997684be853882a59e2c7ca7..f3197ddf2abab9abdbc029def8164f4a748b0d91
2019-10-14 18:34:25 -0300 to 2019-10-29 10:17:40 -0300
- Fix typos (rust-lang/rust-by-example#1285)
- Improve Cargo / Dependencies section (rust-lang/rust-by-example#1287)
- Improve Cargo / Build Scripts section (rust-lang/rust-by-example#1288)
- Make if_let exercise runnable (rust-lang/rust-by-example#1289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

@r1cm3d r1cm3d r1cm3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DieBauer @eddyp @steveklabnik @r1cm3d