cargo 0.73 build broken on windows

[est31]

I updated cargo to 0.73 from crates.io in cargo-udeps (commit) and got the following build failure on ci:

 error[E0432]: unresolved import `windows_sys::Win32::Storage::FileSystem::LockFileEx`
   --> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cargo-0.73.0\src/cargo\util\flock.rs:443:9
    |
443 |         LockFileEx, UnlockFile, LOCKFILE_EXCLUSIVE_LOCK, LOCKFILE_FAIL_IMMEDIATELY,
    |         ^^^^^^^^^^
    |         |
    |         no `LockFileEx` in `Windows::Win32::Storage::FileSystem`
    |         help: a similar name exists in the module: `LockFile`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `cargo` (lib) due to previous error

If you look at the rustdoc for LockFileEx, it writes:

Required features: "Win32_Storage_FileSystem", "Win32_Foundation", "Win32_System_IO"

Compare this with the Cargo.toml of 0.73:

cargo/Cargo.toml

Lines 180 to 188 in 103a7ff

	[target.'cfg(windows)'.dependencies.windows-sys]
	workspace = true
	features = [
	"Win32_Foundation",
	"Win32_Storage_FileSystem",
	"Win32_System_Console",
	"Win32_System_Threading",
	"Win32_System_JobObjects",
	]

The former two are found while Win32_System_IO isn't present. I suppose this is the cause for the failure: in the cargo repo this works fine because of dependency unification and another crate in the DAG enabling the Win32_System_IO features. But if you use cargo from crates.io, then it is not enabled, which is what I ran into.

The fix is simple, just add Win32_System_IO to the list. Ideally this would also be published in a new release.

I have worked around the issue by making cargo-udeps depend on windows-sys and enabling the feature (commit).

[est31]

So apparently with master cargo the issue doesn't occur, as seen in the second commit of my PR est31/cargo-udeps#194 . the third commit uses cargo 0.73 from git and reproduces the issue. The fourth commit applies a patch that just adds Win32_System_IO and it fixes the issue. IDK about beta cargo or what changed to fix the issue until master.

[weihanglo]

Thanks for the report! This was introduced by #12176, which claimed has tested against each crate.

The short term plan here is adding back missing features. In long term we might adding tool like cargo-hack or cargo-hakari to prevent this from happening again.

We might also have a deeper look at #11987, which might not worth pursuing in CI.

Sorry for the inconvenience 😞.

[ehuss]

0.73.1 should be published now.

I opened #12567 to try to figure out if there is some way to avoid this in the future.

[est31]

@ehuss @weihanglo thanks for the quick fix!