Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-1.72.0] add missing windows-sys features back #12565

Merged
merged 6 commits into from
Aug 26, 2023
Merged

[stable-1.72.0] add missing windows-sys features back #12565

merged 6 commits into from
Aug 26, 2023

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 26, 2023 •
edited
Loading

Stable backports:

In order to make CI pass, the following PRs are also cherry-picked:

Fixes #12562

This won't affect Rust releases, i.e. no 1.72.1 will happen. We do this only for release cargo crate.

@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.72.0. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2023
@weihanglo weihanglo mentioned this pull request Aug 26, 2023
Merged
@rustbot rustbot added A-git Area: anything dealing with git A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-manifest Area: Cargo.toml issues A-registries Area: registries A-registry-authentication Area: registry authentication and authorization (authn authz) A-sparse-registry Area: http sparse registries labels Aug 26, 2023
@weihanglo
Copy link
Member Author

All required backports is included. Also bumped the version to 0.73.1.

@ehuss
Copy link
Contributor

ehuss commented Aug 26, 2023

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2023

📌 Commit ac023fc has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@bors
Copy link
Contributor

bors commented Aug 26, 2023

⌛ Testing commit ac023fc with merge 26bba48...

@ehuss ehuss mentioned this pull request Aug 26, 2023
Open
@bors
Copy link
Contributor

bors commented Aug 26, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 26bba48 to rust-1.72.0...

@bors bors merged commit 26bba48 into rust-lang:rust-1.72.0 Aug 26, 2023
20 checks passed
@weihanglo weihanglo deleted the rust-1.72.0-backport branch October 20, 2023 23:58
@ehuss ehuss added this to the 1.72.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
A-git Area: anything dealing with git A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-manifest Area: Cargo.toml issues A-registries Area: registries A-registry-authentication Area: registry authentication and authorization (authn authz) A-sparse-registry Area: http sparse registries S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
6 participants
@weihanglo @rustbot @ehuss @bors @epage @compiler-errors