Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo silently ignores git revision when branch is specified #2695

Closed
Diggsey opened this issue May 15, 2016 · 2 comments
Closed

Cargo silently ignores git revision when branch is specified #2695

Diggsey opened this issue May 15, 2016 · 2 comments

Comments

@Diggsey
Copy link
Contributor

Diggsey commented May 15, 2016

If a dependency specifies both a branch and a commit hash, then the commit hash is silently ignored. Either cargo should error if both are specified, or the commit hash should take precedence (and ideally, if this option is chosen, cargo should check that the specified commit is in the history of the branch).
@matklad matklad mentioned this issue Aug 1, 2016
Merged
bors added a commit that referenced this issue Aug 1, 2016
@bors
Auto merge of #2940 - matklad:ambiguous-deps, r=alexcrichton
3417598 
Warn about unused keys in dependency specification

Closes #2869 and #2695
@matklad
Copy link
Member

matklad commented Dec 16, 2016

Should be closed by #2940!

@alexcrichton
Copy link
Member

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @Diggsey @matklad