Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about unused keys in dependency specification #2940

Merged
merged 1 commit into from
Aug 1, 2016
Merged

Warn about unused keys in dependency specification #2940

merged 1 commit into from
Aug 1, 2016

Conversation

matklad
Copy link
Member

@matklad matklad commented Aug 1, 2016

Closes #2869 and #2695

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 5010618

Thanks!

@bors
Copy link
Collaborator

bors commented Aug 1, 2016

⌛ Testing commit 5010618 with merge 3417598...

bors added a commit that referenced this pull request Aug 1, 2016
@bors
Auto merge of #2940 - matklad:ambiguous-deps, r=alexcrichton
3417598 
Warn about unused keys in dependency specification

Closes #2869 and #2695
@bors
Copy link
Collaborator

bors commented Aug 1, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing 3417598 to master...

@bors bors merged commit 5010618 into rust-lang:master Aug 1, 2016
@bors bors mentioned this pull request Aug 1, 2016
Merged
@matklad matklad deleted the ambiguous-deps branch August 19, 2016 22:45
@matklad matklad mentioned this pull request Dec 16, 2016
Closed
@ehuss ehuss mentioned this pull request Dec 16, 2020
Merged
bors added a commit that referenced this pull request Dec 16, 2020
@bors
Auto merge of #8984 - ehuss:reject-ambiguous-git, r=Eh2406
fde8ee3 
Reject ambiguous git dependency declaration.

This rejects a git dependency that specifies more than one of `branch`, `tag`, or `rev`. Cargo does not handle this case very well, and this warning has been in place for 4 years (since #2940).

Fixes #7841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matklad @rust-highfive @alexcrichton @bors