Add -Z check-cfg-features to enable compile-time checking of features #10408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Urgau
force-pushed
the
check-cfg-features
branch
from
412e794
to
03fbb2e
Compare
|
Nice, thanks! Would you be up for also adding a test for the up-and-coming namespaced features to ensure that works well too? For example having a test that uses |
…tion issues See https://github.com/rust-lang/cargo/runs/5290789288?check_suite_focus=true Where the expected is: --check-cfg 'values(feature, "f_a", "f_b")' But we got: --check-cfg "values(feature, /"f_a/", /"f_b/")"
Done in 4ac4f3d. And just to confirm, in case below |
|
I believe so, yes, thanks! |
|
@bors: r+ |
|
📌 Commit 4ac4f3d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Feb 22, 2022
Closed
Closed
3 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2022
Update cargo 8 commits in ea2a21c994ca1e4d4c49412827b3cf4dcb158b1d..d6cdde584a1f15ea086bae922e20fd27f7165431 2022-02-15 04:24:07 +0000 to 2022-02-22 19:55:51 +0000 - Add common profile validation. (rust-lang/cargo#10411) - Add -Z check-cfg-features to enable compile-time checking of features (rust-lang/cargo#10408) - Remove invalid target-specific dependency example. (rust-lang/cargo#10401) - Fix errors in `cargo fetch` usage guide (rust-lang/cargo#10398) - Fix some broken doc links. (rust-lang/cargo#10404) - Implement "artifact dependencies" (RFC-3028) (rust-lang/cargo#9992) - Print executable name on cargo test --no-run rust-lang/cargo#2 (rust-lang/cargo#10346) - Avoid new deprecation warnings from clap 3.1.0 (rust-lang/cargo#10396)
bors
added a commit
that referenced
this pull request
Feb 27, 2022
Add -Z check-cfg-features support for rustdoc This PR is a follow to #10408 where support for compile-time checking of features was implemented for `rustc`. At the time `rustdoc` support wasn't yet merged, but now that it has been [merged](rust-lang/rust#94154), this pull-request add support for it in the `doc` and `test --doc` (doctest) mode. r? `@alexcrichton`
2 tasks
bors
added a commit
that referenced
this pull request
Apr 12, 2022
Add support for rustc --check-cfg well known names and values This pull-request add support for `rustc` `--check-cfg` well known names and values. ### What does this PR try to resolve? This pull-request add support for `rustc` `--check-cfg` well known names and values: - `-Z check-cfg-well-known-names`: `--check-cfg names()` well known names - `-Z check-cfg-well-known-values`: `--check-cfg values()` well known values ### How should we test and review this PR? #### Testing `cargo check -Z check-cfg-well-known-names` and `cargo check -Z check-cfg-well-known-values` #### Review This PR contains one commit that split `features_args` into `check_cfg_args`, add the well known support in it, adds call to that new function and add documentation and test for those new flags. ### Additional information This was implemented as two new additional flags because it's most likely that these flags will not be stabilize at the same time and also because some of these flags may become the default. RFC: rust-lang/rfcs#3013 `-Z check-cfg-features`: #10408 `cargo doc` support: #10428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request implements the "Cargo support" section of RFC 3013: Checking conditional compilation at compile time.
The support is added in the form of an new unstable flags:
-Z check-cfg-featuresthat pass all possible features of a package torustcunstable--check-cfgcommand line as--check-cfg=values(feature, ...). This enables compile time checking offeaturevalues in#[cfg],cfg!and#[cfg_attr].This new flag currently only affects
rustcbutrustdocsupport will be added as soon as it's support is merged.Note than the intent is that this command line options become the default when stabilizing as suggested in the RFC: