Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable two windows tests #10930

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Enable two windows tests #10930

merged 2 commits into from
Aug 11, 2022

Commits on Aug 2, 2022

  1. Re-enable killing_cargo_releases_the_lock on windows. 

    AFAICT, we do not test on these older platforms anymore.
Regardless, the test seems to work fine on 32-bit windows-gnu
on Windows 10.

See rust-lang#3102 (comment)
where it was originally disabled.
    @ehuss
    ehuss committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    01747aa View commit details
    Browse the repository at this point in the history

  2. Re-enable version_works_without_rustc on windows. 

    This test was ignored in rust-lang#3189
without much discussion of explaining why.

AFAICT, this test works fine on Windows on both MSVC and GNU.
Empty paths do the expected behavior (preventing cargo from running
rustc). There are some special rules on Windows about discovering the
process to run (such as searching the app's launch directory), but
I do not think that is relevant here. Confirmed by trying to run
`cargo check` in this test fails to find `rustc`.
    @ehuss
    ehuss committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    c0be32b View commit details
    Browse the repository at this point in the history