Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: registry data kinds cleanup #12248

Merged
merged 5 commits into from
Jun 10, 2023
Merged

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Found some places needing tiny refactors during documenting #12247

How should we test and review this PR?

Commit by commit. Each has its own explanation.

I don't think there is anything controversial.

The relevant part was removed in 1daff03
LAST_UPDATED_FILE was never used even before rust-lang#6880.
They were just leftover during the PR updates.
It is not used anywhere other than in module `registry::download`.
At least doc duplicate can be eliminiated
@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-local-registry-source Area: local registry sources (vendoring) A-networking Area: networking issues, curl, etc. A-registries Area: registries A-sparse-registry Area: http sparse registries Command-package S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2023
@epage
Copy link
Contributor

epage commented Jun 10, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2023

📌 Commit 008501a has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2023
@bors
Copy link
Contributor

bors commented Jun 10, 2023

⌛ Testing commit 008501a with merge 928b956...

@bors
Copy link
Contributor

bors commented Jun 10, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 928b956 to master...

@bors bors merged commit 928b956 into rust-lang:master Jun 10, 2023
@weihanglo weihanglo deleted the source-refactor branch June 10, 2023 06:05
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2023
Update cargo

11 commits in 49b6d9e179a91cf7645142541c9563443f64bf2b..0c14026aa84ee2ec4c67460c0a18abc8519ca6b2
2023-06-09 17:21:19 +0000 to 2023-06-14 18:43:05 +0000
- fix(embedded): Don't append hash to bin names (rust-lang/cargo#12269)
- Fix version requirement example in Dependency Resolution, SemVer compatibility section (rust-lang/cargo#12267)
- Update triagebot links. (rust-lang/cargo#12265)
- Show a better error when container tests fail. (rust-lang/cargo#12264)
- chore: update dependencies (rust-lang/cargo#12261)
- refactor(embedded) (rust-lang/cargo#12262)
- docs: clarify the use of `default` branch instead of `main` by default (rust-lang/cargo#12251)
- docs: update changelog for 1.71 backport and 1.72 (rust-lang/cargo#12256)
- feat: Initial support for single-file packages (rust-lang/cargo#12245)
- test(z-flags): Verify `-Z` flags list is sorted (rust-lang/cargo#12224)
- refactor: registry data kinds cleanup (rust-lang/cargo#12248)

---

This commit also update LICENSE exceptions, as Cargo introduced a newer version of `dunce` and `blake3` as dependencies.

r? `@ghost`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jun 16, 2023
Update cargo

11 commits in 49b6d9e179a91cf7645142541c9563443f64bf2b..0c14026aa84ee2ec4c67460c0a18abc8519ca6b2
2023-06-09 17:21:19 +0000 to 2023-06-14 18:43:05 +0000
- fix(embedded): Don't append hash to bin names (rust-lang/cargo#12269)
- Fix version requirement example in Dependency Resolution, SemVer compatibility section (rust-lang/cargo#12267)
- Update triagebot links. (rust-lang/cargo#12265)
- Show a better error when container tests fail. (rust-lang/cargo#12264)
- chore: update dependencies (rust-lang/cargo#12261)
- refactor(embedded) (rust-lang/cargo#12262)
- docs: clarify the use of `default` branch instead of `main` by default (rust-lang/cargo#12251)
- docs: update changelog for 1.71 backport and 1.72 (rust-lang/cargo#12256)
- feat: Initial support for single-file packages (rust-lang/cargo#12245)
- test(z-flags): Verify `-Z` flags list is sorted (rust-lang/cargo#12224)
- refactor: registry data kinds cleanup (rust-lang/cargo#12248)

---

This commit also update LICENSE exceptions, as Cargo introduced a newer version of `dunce` and `blake3` as dependencies.

r? `@ghost`
@ehuss ehuss added this to the 1.72.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-local-registry-source Area: local registry sources (vendoring) A-networking Area: networking issues, curl, etc. A-registries Area: registries A-sparse-registry Area: http sparse registries Command-package S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants