fix(embedded): Don't append hash to bin names

[epage]

What does this PR try to resolve?

More immediately, this is to unblock rust-lang/rust#112601

The hash existed for sharing a target directory. That code isn't
implemented yet and a per-user build cache might remove the need for it,
so let's remove it for now and more carefully weigh adding it back in.

In general, this is also the more appropriate way for a feature that would be first class.

How should we test and review this PR?

This originally built on #12268 but now stands alone as the other PR has windows issues to work out

Additional information

[rustbot]

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

[weihanglo]

Make sense. I was going to suggest using crate::util::hex::short_hash against manifest string, but just realize the bin name will be uplifted to target/debug. That means if someone edit-and-runs the script many times, a lot of executables will mess up target/debug directory.

[weihanglo]

@bors r+

Thanks!

[bors]

📌 Commit 56b2812 has been approved by weihanglo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 56b2812 with merge 0c14026...

[bors]

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 0c14026 to master...

[guest271314]

Is there official documentation for how this works, and what the bare required folders and files are from Rust nightly release?

[epage]

The documentation is at https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#script

Unsure what you mean by files and folders.

[guest271314]

Unsure what you mean by files and folders.

It's basically impossible to download the entire Rust toolchain on a temporary file system running a live Linux session.

So I fetched the Nightly archive, immediately got rid of the 600+ MB documentation folder, and everything else except rustc and rust-std-x86_64-unknown-linux-gnu folders.

I'll re-fetch the nightly archive and extract cargo folder.
Eventually I got this to run, using -L to I guess link to rustlib/x86_64-unknown-linux-gnu/lib

#!/bin/sh
//bin/bash -ec '[ "$0" -nt "${0%.*}" ] && /home/user/bin/rustc/bin/rustc -L /home/user/bin/rust-std-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib "$0" -o "${0%.*}"; "${0%.*}" "$@"' "$0" "$@"; exit $?

use std::env;
// https://stackoverflow.com/a/75981598
fn main() {
  let args: Vec<String> = env::args().collect();
  if args.len() > 1 {
      println!("Hello {}!", &args[1]);
  } else {
      println!("Hello world!");
  }
}

What I'm really working on doing is using Rust .rs file as a Native Messaging host script.

I converted a working C version to Rust using https://c2rust.com/.

Now I have to figure out how to link to libc in the resulting file https://gist.github.com/rust-play/92af6fefec0ea8bcc76a5b18be40005e

//https://stackoverflow.com/q/41322300
//https://c2rust.com/
//https://github.com/rust-lang/rust/issues/1772
#![allow(dead_code, mutable_transmutes, non_camel_case_types, non_snake_case, non_upper_case_globals, unused_assignments, unused_mut)]
#![register_tool(c2rust)]
#![feature(register_tool)]
extern "C" {
    static mut stdin: *mut _IO_FILE;
    static mut stdout: *mut _IO_FILE;
    fn fflush(__stream: *mut FILE) -> libc::c_int;
// ...

Just to see what would happen if I was trying to compile the C to Rust code

./rust.sh "test"
error[E0433]: failed to resolve: use of undeclared crate or module `libc`
  --> ./rust.sh:10:39

// ...

118 |         free(message as *mut libc::c_void);
    |                              ^^^^ use of undeclared crate or module `libc`

error: aborting due to 58 previous errors

For more information about this error, try `rustc --explain E0433`.

This is my second time trying to use Rust to build something. My first time using Rust as a script. Thanks.

[epage]

@guest271314 a long-merged PR for an unrelated part of a feature that it doesn't look like you are using from your examples is likely not the best place for us to be having this conversation. For user support, https://users.rust-lang.org/ tends to be a good place to go.

[guest271314]

@epage Thanks.

I was replying to

Unsure what you mean by files and folders.

And included my use case for context.

Have a great day.

[guest271314]

a long-merged PR for an unrelated part of a feature that it doesn't look like you are using from your examples

The links in my research led me here.

[guest271314]

@epage Is there anything special I need to do to avoid "no such command: +nightly"?

 cargo/bin/cargo +nightly -Zscript ~/bin/script.rs
error: no such command: `+nightly`

	Cargo does not handle `+toolchain` directives.
	Did you mean to invoke `cargo` through `rustup` instead?

[weihanglo]

@guest271314 If you are not using cargo via rustup, you don't need to pass the +nightly argument.

Anyhow, this PR was closed a year ago. If you have feedback for -Zscript feature, please consider opening a new issue instead of leaving a comment here.

[guest271314]

@weihanglo #14363