refactor(registry): extract and rearrange items to their own modules #12290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be honest I don't even feel like they belong here. Maybe we should have a dedicated directory for registry-related code.
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-cli
weihanglo
force-pushed
the
refactor-registry-api
branch
from
78a6727 to
bc16c05
Compare
rustbot
added
the
A-infrastructure
epage
reviewed
Jun 20, 2023
weihanglo
commented
Jun 20, 2023
weihanglo
force-pushed
the
refactor-registry-api
branch
from
bc16c05 to
aaf0221
Compare
|
This is ready for a new round of review. Please call out if there is something inappropriate. |
|
@bors r+ |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 1, 2023
Update cargo 6 commits in 03bc66b55c290324bd46eb22e369c8fae1908f91..5b377cece0e0dd0af686cf53ce4637d5d85c2a10 2023-06-23 23:27:46 +0000 to 2023-06-30 00:01:00 +0000 - Add READMEs for the credential helpers. (rust-lang/cargo#12322) - Add some more documentation for Source download functions. (rust-lang/cargo#12319) - Don't try to compile cargo-credential-gnome-secret on non-Linux platforms. (rust-lang/cargo#12321) - refactor: use macro to remove duplication of workspace inheritable fields getters (rust-lang/cargo#12317) - doc: should be `.cargo-ok` (rust-lang/cargo#12318) - refactor(registry): extract and rearrange items to their own modules (rust-lang/cargo#12290) r? `@ghost`
bors
added a commit
that referenced
this pull request
Aug 28, 2023
Set tracing target for networking messages. This changes the log messages for messages related to network traffic to use the "network" tracing target. This makes it easier to do `CARGO_LOG=network=trace CARGO_HTTP_DEBUG=true` instead of trying to figure out which modules to include (and to avoid `CARGO_LOG=trace` which can be too noisy). For example, #12290 moved the location of some log messages to a different module, which broke the documented workflow of using `CARGO_LOG=cargo::ops::registry=debug` to get networking information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
A refactor moving things to their own new modules.
How should we test and review this PR?
Commit by commit.
The PR just moves things around. I know it's a bit painful to see this kinda of change but to have a better module hierarchy we need to do it now or later.
Additional information
This was done during coping with todos of asymmetric tokens #10519.