Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more documentation for Source download functions. #12319

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jun 29, 2023

This adds a little more of a description to the download functions of the Source trait, since the behavior wasn't clear to me (and I often forget how these work).

@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2023
@epage
Copy link
Contributor

epage commented Jun 29, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 29, 2023

📌 Commit 6058814 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2023
@weihanglo
Copy link
Member

@bors r=epage

This didn't get into bors queue.

@bors
Copy link
Contributor

bors commented Jun 29, 2023

📌 Commit 03d9c5b has been approved by epage

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 29, 2023

⌛ Testing commit 03d9c5b with merge 2d205ee...

@bors
Copy link
Contributor

bors commented Jun 30, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 2d205ee to master...

@bors bors merged commit 2d205ee into rust-lang:master Jun 30, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 1, 2023
Update cargo

6 commits in 03bc66b55c290324bd46eb22e369c8fae1908f91..5b377cece0e0dd0af686cf53ce4637d5d85c2a10
2023-06-23 23:27:46 +0000 to 2023-06-30 00:01:00 +0000
- Add READMEs for the credential helpers. (rust-lang/cargo#12322)
- Add some more documentation for Source download functions. (rust-lang/cargo#12319)
- Don't try to compile cargo-credential-gnome-secret on non-Linux platforms. (rust-lang/cargo#12321)
- refactor: use macro to remove duplication of workspace inheritable fields getters (rust-lang/cargo#12317)
- doc: should be `.cargo-ok` (rust-lang/cargo#12318)
- refactor(registry): extract and rearrange items to their own modules (rust-lang/cargo#12290)

r? `@ghost`
@ehuss ehuss added this to the 1.72.0 milestone Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants