Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing strip entries in dev and release profiles. #12748

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add missing strip entries in dev and release profiles. #12748

merged 1 commit into from
Sep 28, 2023

Conversation

nnethercote
Copy link
Contributor

The docs for the dev and release profiles mention 10 of the 11 possible profile settings. This commit adds the missing strip entries.

@nnethercote
Add missing strip entries in dev and release profiles.
5649773 
The docs for the `dev` and `release` profiles mention 10 of the 11
possible profile settings. This commit adds the missing `strip` entries.
@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
weihanglo
weihanglo approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

I am just about to submit exactly the same PR 😆.

For the reference, this comes from Profile::default():

cargo/src/cargo/core/profiles.rs

Lines 603 to 623 in e6aabe8

impl Default for Profile {
fn default() -> Profile {
Profile {
name: InternedString::new(""),
opt_level: InternedString::new("0"),
root: ProfileRoot::Debug,
lto: Lto::Bool(false),
codegen_backend: None,
codegen_units: None,
debuginfo: DebugInfo::Resolved(TomlDebugInfo::None),
debug_assertions: false,
split_debuginfo: None,
overflow_checks: false,
rpath: false,
incremental: false,
panic: PanicStrategy::Unwind,
strip: Strip::None,
rustflags: vec![],
}
}
}

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 28, 2023

📌 Commit 5649773 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
@bors
Copy link
Contributor

bors commented Sep 28, 2023

⌛ Testing commit 5649773 with merge 84445c6...

@bors
Copy link
Contributor

bors commented Sep 28, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 84445c6 to master...

@bors bors merged commit 84445c6 into rust-lang:master Sep 28, 2023
19 of 20 checks passed
@nnethercote nnethercote deleted the add-missing-strip branch September 28, 2023 10:07
@weihanglo weihanglo mentioned this pull request Sep 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2023
@bors
Auto merge of rust-lang#116280 - weihanglo:update-cargo, r=weihanglo
1770912 
Update cargo

4 commits in e6aabe8b3fcf639be3a5bf68e77853bd7b3fa27d..59596f0f31a94fde48b5aa7e945cd0b7ceca9620
2023-09-26 16:31:53 +0000 to 2023-09-29 19:29:17 +0000
- refactor: Switch from termcolor to anstream (rust-lang/cargo#12751)
- Add missing `strip` entries in `dev` and `release` profiles. (rust-lang/cargo#12748)
- Add better suggestion for the unsupported silent flag (rust-lang/cargo#12723)
- docs(ref): Establish publish best practices (rust-lang/cargo#12745)

r? ghost
nnethercote added a commit to nnethercote/cargo that referenced this pull request Sep 30, 2023
@nnethercote
Add more missing strip info to docs.
cec4e77 
This is a follow-up to rust-lang#12748.
@nnethercote nnethercote mentioned this pull request Sep 30, 2023
Merged
@ehuss ehuss added this to the 1.74.0 milestone Sep 30, 2023
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Sep 30, 2023
@bors
Auto merge of #116280 - weihanglo:update-cargo, r=weihanglo
50ed648 
Update cargo

4 commits in e6aabe8b3fcf639be3a5bf68e77853bd7b3fa27d..59596f0f31a94fde48b5aa7e945cd0b7ceca9620
2023-09-26 16:31:53 +0000 to 2023-09-29 19:29:17 +0000
- refactor: Switch from termcolor to anstream (rust-lang/cargo#12751)
- Add missing `strip` entries in `dev` and `release` profiles. (rust-lang/cargo#12748)
- Add better suggestion for the unsupported silent flag (rust-lang/cargo#12723)
- docs(ref): Establish publish best practices (rust-lang/cargo#12745)

r? ghost
nnethercote added a commit to nnethercote/cargo that referenced this pull request Oct 1, 2023
@nnethercote
Add more missing strip info to docs.
78f697f 
Also change some `strip = false` mentions to `strip = "false"`.

This is a follow-up to rust-lang#12748.
bors added a commit that referenced this pull request Oct 1, 2023
@bors
Auto merge of #12754 - nnethercote:more-strip, r=weihanglo
9a7a04f 
Add more missing `strip` info to docs.

This is a follow-up to #12748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@ehuss ehuss

Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rustbot @weihanglo @bors @ehuss