Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more missing strip info to docs. #12754

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Conversation

nnethercote
Copy link
Contributor

This is a follow-up to #12748.

@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2023
@nnethercote
Copy link
Contributor Author

The default values in #12748 were strip = false but the pre-existing entry moved here has strip = "none". I don't know which is preferable, but consistency would be good.

Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values in #12748 were strip = false but the pre-existing entry moved here has strip = "none". I don't know which is preferable, but consistency would be good.

If there is a pre-existing strip = "none", could you help update change in #12748 to "none"?

Also change some `strip = false` mentions to `strip = "false"`.

This is a follow-up to rust-lang#12748.
@nnethercote
Copy link
Contributor Author

If there is a pre-existing strip = "none", could you help update change in #12748 to "none"?

Done. I also added a tiny new commit that changes some * default: ... entries to * Default: ... for consistency with other such entries.

@weihanglo
Copy link
Member

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 1, 2023

📌 Commit f506b5a has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2023
@bors
Copy link
Collaborator

bors commented Oct 1, 2023

⌛ Testing commit f506b5a with merge 9a7a04f...

@bors
Copy link
Collaborator

bors commented Oct 1, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 9a7a04f to master...

@bors bors merged commit 9a7a04f into rust-lang:master Oct 1, 2023
20 checks passed
@nnethercote nnethercote deleted the more-strip branch October 1, 2023 21:49
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2023
Update cargo

9 commits in 59596f0f31a94fde48b5aa7e945cd0b7ceca9620..794d0a82547f3081044c0aca7b6083733ce51344
2023-09-29 19:29:17 +0000 to 2023-10-03 23:19:33 +0000
- Prep for automating MSRV management (rust-lang/cargo#12767)
- chore(deps): update rust crate itertools to 0.11.0 (rust-lang/cargo#12759)
- fix bug: corruption when cargo killed while writing (rust-lang/cargo#12744)
- Disable custom_target::custom_bin_target on windows-gnu (rust-lang/cargo#12763)
- chore(deps): update compatible (rust-lang/cargo#12757)
- Add more missing `strip` info to docs. (rust-lang/cargo#12754)
- chore(deps): update actions/checkout action to v4 (rust-lang/cargo#12762)
- chore(deps): update rust crate cargo_metadata to 0.18.0 (rust-lang/cargo#12758)
- fix(test): Add back in newlines to diffs (rust-lang/cargo#12753)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants