-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Remove plugin tests #12921
tests: Remove plugin tests #12921
Conversation
Compiler plugins were removed in rust-lang/rust#116412, so we don't need these tests. As for the `plugin` field on build-targets, it appears to be [stable-but-deprecated](https://doc.rust-lang.org/cargo/reference/cargo-targets.html#the-plugin-field), so I left it alone
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. Thanks you.
@bors r+ |
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Update cargo 7 commits in 65e297d1ec0dee1a74800efe600b8dc163bcf5db..7046d992f9f32ba209a8079f662ebccf9da8de25 2023-11-03 20:56:31 +0000 to 2023-11-08 03:24:57 +0000 - fix: Report more detailed semver errors (rust-lang/cargo#12924) - Fix some broken links in the man pages (rust-lang/cargo#12929) - Add better error message when it can not find the search section (rust-lang/cargo#12865) - Bug 12920 (rust-lang/cargo#12923) - Update link in environment-variables.md (rust-lang/cargo#12922) - refactor(toml): Pull out the schema (rust-lang/cargo#12911) - tests: Remove plugin tests (rust-lang/cargo#12921) r? ghost
Compiler plugins were removed in rust-lang/rust#116412, so we don't need these tests.
As for the
plugin
field on build-targets, it appears to be stable-but-deprecated, so I left it alone