Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 12920 #12923

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Bug 12920 #12923

merged 2 commits into from
Nov 6, 2023

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Nov 6, 2023

Fix for #12920, a regression introduced in #12749.

This also as a test case for an existing Terrible error message.

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-semver Area: semver specifications, version matching, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2023
@epage
Copy link
Contributor

epage commented Nov 6, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 6, 2023

📌 Commit 7997306 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2023
@bors
Copy link
Collaborator

bors commented Nov 6, 2023

⌛ Testing commit 7997306 with merge f095603...

@bors
Copy link
Collaborator

bors commented Nov 6, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing f095603 to master...

@bors bors merged commit f095603 into rust-lang:master Nov 6, 2023
20 checks passed
@Eh2406 Eh2406 deleted the bug_12920 branch November 6, 2023 22:26
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2023
Update cargo

7 commits in 65e297d1ec0dee1a74800efe600b8dc163bcf5db..7046d992f9f32ba209a8079f662ebccf9da8de25
2023-11-03 20:56:31 +0000 to 2023-11-08 03:24:57 +0000
- fix: Report more detailed semver errors (rust-lang/cargo#12924)
- Fix some broken links in the man pages (rust-lang/cargo#12929)
- Add better error message when it can not find the search section (rust-lang/cargo#12865)
- Bug 12920 (rust-lang/cargo#12923)
- Update link in environment-variables.md (rust-lang/cargo#12922)
- refactor(toml): Pull out the schema (rust-lang/cargo#12911)
- tests: Remove plugin tests (rust-lang/cargo#12921)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semver Area: semver specifications, version matching, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants