-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guidance on setting homepage in manifest #13293
Conversation
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
@@ -244,9 +244,13 @@ package. | |||
```toml | |||
[package] | |||
# ... | |||
homepage = "https://serde.rs/" | |||
homepage = "https://serde.rs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted trailing slash to match the real serde. https://github.com/serde-rs/serde/blob/v1.0.195/serde/Cargo.toml#L10
@@ -255,7 +259,7 @@ package. | |||
```toml | |||
[package] | |||
# ... | |||
repository = "https://github.com/rust-lang/cargo/" | |||
repository = "https://github.com/rust-lang/cargo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted trailing slash to match the real cargo.
Line 18 in 92395d9
repository = "https://github.com/rust-lang/cargo" |
Pretty reasonable to make them less redundant. @bors r+ |
☀️ Test successful - checks-actions |
Update cargo 10 commits in 84976cd699f4aea56cb3a90ce3eedeed9e20d5a5..1cff2ee6b92e0ad3f87c44b70b28f788b2528b3c 2024-01-12 15:55:43 +0000 to 2024-01-16 16:56:57 +0000 - doc: add a heading to highlight "How to find features enabled on dependencies" (rust-lang/cargo#13305) - fix(cargo-update): `--precise` accept arbitrary git revisions (rust-lang/cargo#13250) - Strip debuginfo when debuginfo is not requested (rust-lang/cargo#13257) - Update ahash dependency to 0.8.7 (rust-lang/cargo#13301) - docs: add more links to pkgid spec chapter (rust-lang/cargo#13298) - fix(metadata): Stabilize id format as PackageIDSpec (rust-lang/cargo#12914) - Introduce `-Zprecise-pre-release` unstable flag (rust-lang/cargo#13296) - Delete sentence about parentheses being unsupported in license (rust-lang/cargo#13292) - Add guidance on setting homepage in manifest (rust-lang/cargo#13293) - Clarify the function of the test options (rust-lang/cargo#13236) r? ghost
Carried over from the Rust API Guidelines: https://rust-lang.github.io/api-guidelines/documentation.html#cargotoml-includes-all-common-metadata-c-metadata
This guidance has been in place since 6.5 years ago (rust-lang/api-guidelines@350619f).