Update cargo

[weihanglo]

10 commits in 84976cd699f4aea56cb3a90ce3eedeed9e20d5a5..1cff2ee6b92e0ad3f87c44b70b28f788b2528b3c
2024-01-12 15:55:43 +0000 to 2024-01-16 16:56:57 +0000

• doc: add a heading to highlight "How to find features enabled on dependencies" (doc: add a heading to highlight "How to find features enabled on dependencies" cargo#13305)
• fix(cargo-update): --precise accept arbitrary git revisions (fix(cargo-update): --precise accept arbitrary git revisions cargo#13250)
• Strip debuginfo when debuginfo is not requested (Strip debuginfo when debuginfo is not requested cargo#13257)
• Update ahash dependency to 0.8.7 (Update ahash dependency to 0.8.7 cargo#13301)
• docs: add more links to pkgid spec chapter (docs: add more links to pkgid spec chapter cargo#13298)
• fix(metadata): Stabilize id format as PackageIDSpec (fix(metadata): Stabilize id format as PackageIDSpec  cargo#12914)
• Introduce -Zprecise-pre-release unstable flag (Introduce -Zprecise-pre-release unstable flag cargo#13296)
• Delete sentence about parentheses being unsupported in license (Delete sentence about parentheses being unsupported in license cargo#13292)
• Add guidance on setting homepage in manifest (Add guidance on setting homepage in manifest cargo#13293)
• Clarify the function of the test options (Clarify the function of the test options cargo#13236)

r? ghost

[rustbot]

Some changes occurred in src/tools/cargo

cc @ehuss

[weihanglo]

@bors r+ p=1 rollup=never

[bors]

📌 Commit 7e1e61a has been approved by weihanglo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7e1e61a with merge 6ed31ab...

[bors]

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 6ed31ab to master...

[rust-timer]

Finished benchmarking commit (6ed31ab): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.5%]	2
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-16.8%	[-47.6%, -0.4%]	13
Improvements ✅ (secondary)	-20.5%	[-46.9%, -2.2%]	37
All ❌✅ (primary)	-14.5%	[-47.6%, 0.5%]	15

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.6%, 3.6%]	1
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-1.3%	[-2.2%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-2.2%, 3.6%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-16.7%	[-35.3%, -1.5%]	9
Improvements ✅ (secondary)	-15.7%	[-34.5%, -2.0%]	35
All ❌✅ (primary)	-16.7%	[-35.3%, -1.5%]	9

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 664.632s -> 663.655s (-0.15%)
Artifact size: 308.32 MiB -> 308.29 MiB (-0.01%)

[Kobzol]

This is most likely the effect of rust-lang/cargo#13257. But it's weird that binary size wasn't reduced 🤔

Edit: binary size was reduced, but rustc-perf currently has a bug that prevents it from being shown. A PR with a fix is already up.

[lqd]

Stripping by default feels significant enough that it could be mentioned in the release notes?

[weihanglo]

Stripping by default feels significant enough that it could be mentioned in the release notes?

Yeah. The Cargo PR has already got relnote label.

[Kobzol]

Perf. wins outweigh the losses by a lot, and this was a Cargo update anyway, so not much we could do.

@rustbot label: +perf-regression-triaged