-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement install --all #5060
Implement install --all #5060
Conversation
This patch tries to implement `cargo install --all` for installing all "bin" crates from a workspace project. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! Could you be sure to add a test for this as well? @matklad this may end up being somewhat orthogonal to that as "install the package/workspace at cwd" I think may just become a flag rather than being implicit |
I am also unsure how this should interact with For example, I believe that if you have a crate which contains an example, but does not contain a binary, than My gut feeling (which might be totally wrong! :) ) is that we should try do use the same semantics for Lines 103 to 105 in ed8dfce
|
Hm true yeah! I agree we should add |
☔ The latest upstream changes (presumably #5152) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm gonna close this for now as it's pretty out of date at this point, but it can of course be resubmitted! |
This patch tries to implement
cargo install --all
for installing all"bin" crates from a workspace project.
Signed-off-by: Matthias Beyer mail@beyermatthias.de
I doubt that it is this simple, but I guess this is the first step.
Closes #4101
My
cargo test
fails, but I guess that's not because of my changes but rather because I cannot crosscompile: