Clap #5152
Clap #5152
Conversation
| pub mod update; | ||
| pub mod verify_project; | ||
| pub mod version; | ||
| pub mod yank; |
There was a problem hiding this comment.
This file contains some copy-paste. We can combat it resurrecting original for_each_subcommand macro, though I prefer not to do this, because X Macros are hard to undestand to new contributors and to stupid IDEs :)
We could also coalesce builtin_exec and builtin into a single function probably, but I don't think it'll buy us much, and it was simpler to implement builtin_exec using multiple cursors :)
Done! I think all the comments should be addressed now? Hope there aren't much quite bugs left :) |
|
@bors: r+ 🎊 |
|
📌 Commit 6b9c063 has been approved by |
Clap Reopening of #5129 So, looks like all tests are 🍏 on my machine! I definitely want to refactor it some more, and also manually checked that we haven't regressed any help messages, but all the major parts are in place already.
|
☀️ Test successful - status-appveyor, status-travis |
This notably includes * rust-lang/cargo#5152 * rust-lang/cargo#5188 The first one switches cargo from docopt to clap ( we also update to the latest calp in this repository), the second one should help us to unify feature flags for Cargo itself and RLS, and build Cargo libray only once.
From reviewing the history this looks like a copy-paste error while porting to clap (rust-lang#5152): this is fetch's after_help info
Reopening of #5129
So, looks like all tests are 🍏 on my machine!
I definitely want to refactor it some more, and also manually checked that we haven't regressed any help messages, but all the major parts are in place already.