Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BETA] Partially destabilize edition. #6216

Merged
merged 1 commit into from
Oct 24, 2018
Merged

[BETA] Partially destabilize edition. #6216

merged 1 commit into from
Oct 24, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 24, 2018

Removes edition from cargo new, and documentation.

Also includes (parts of) #6176 and #6027 to get the beta branch to pass tests on CI.

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.30.0. Please double check that you specified the right target!

@ehuss
Copy link
Contributor Author

ehuss commented Oct 24, 2018

cc @pietroalbini
r? @Mark-Simulacrum

For reference, the edition setting in Cargo.toml is left as stable. If you attempt to set it, it will result in an error that looks like:

   Compiling ed2 v0.1.0 (/Users/eric/Proj/rust/cargo/scratch/ed2)
error: Edition 2018 is unstable and only available for nightly builds of rustc.

error: Could not compile `ed2`.

I'm not sure if there are other real consequences to that. You might be able to publish, but maybe that's not too important?

@Mark-Simulacrum
Copy link
Member

I think that "unbuildable" is perfectly acceptable -- I don't expect that we'll have any changes to edition key in toml anyway.

@bors r+ p=100

@bors
Copy link
Contributor

bors commented Oct 24, 2018

📌 Commit 12704b6 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Oct 24, 2018

⌛ Testing commit 12704b6 with merge 2ee151f...

bors added a commit that referenced this pull request Oct 24, 2018
@bors
Auto merge of #6216 - ehuss:destabilize-edition, r=Mark-Simulacrum
2ee151f 
[BETA] Partially destabilize edition.

Removes edition from `cargo new`, and documentation.

Also includes (parts of) #6176 and #6027 to get the beta branch to pass tests on CI.
@bors
Copy link
Contributor

bors commented Oct 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 2ee151f to rust-1.30.0...

@bors bors merged commit 12704b6 into rust-lang:rust-1.30.0 Oct 24, 2018
@ehuss ehuss mentioned this pull request Oct 25, 2018
Merged
bors added a commit to rust-lang/rust that referenced this pull request Oct 26, 2018
@bors
Auto merge of #55362 - ehuss:releases-cargo-new-edition, r=Mark-Simul…
82239b0 
…acrum

Remove `cargo new --edition` from release notes.

This was removed at the last minute (#55315, rust-lang/cargo#6216).
Apologies for not catching this.
@dwijnand dwijnand mentioned this pull request Oct 27, 2018
Closed
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this pull request Nov 7, 2018
@bors @Mark-Simulacrum
Auto merge of rust-lang#55362 - ehuss:releases-cargo-new-edition, r=M…
d6cd7bb 
…ark-Simulacrum

Remove `cargo new --edition` from release notes.

This was removed at the last minute (rust-lang#55315, rust-lang/cargo#6216).
Apologies for not catching this.
@ehuss ehuss added this to the 1.30.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
None yet
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rust-highfive @Mark-Simulacrum @bors @matklad