Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo new --edition from release notes. #55362

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 25, 2018

This was removed at the last minute (#55315, rust-lang/cargo#6216).
Apologies for not catching this.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1 (want to land before beta promotion, but feel free to rollup)

@bors
Copy link
Contributor

bors commented Oct 25, 2018

📌 Commit 19c4e36 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2018
@bors
Copy link
Contributor

bors commented Oct 26, 2018

⌛ Testing commit 19c4e36 with merge 82239b0...

bors added a commit that referenced this pull request Oct 26, 2018
…acrum

Remove `cargo new --edition` from release notes.

This was removed at the last minute (#55315, rust-lang/cargo#6216).
Apologies for not catching this.
@bors
Copy link
Contributor

bors commented Oct 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 82239b0 to master...

@bors bors merged commit 19c4e36 into rust-lang:master Oct 26, 2018
bors added a commit that referenced this pull request Oct 29, 2018
[beta]: Prepare the 1.31.0 beta release

* Update to Cargo's branched 1.31.0 branch
* Update the channel to `beta`

Rolled up beta-accepted PRs:

* #55362: Remove `cargo new --edition` from release notes.
* #55325: Fix link to macros chapter
* #55358: Remove redundant clone (2)
* #55346: Shrink `Statement`.
* #55274: Handle bindings in substructure of patterns with type ascriptions
* #55297: Partial implementation of uniform paths 2.0 to land before beta
* #55192: Fix ordering of nested modules in non-mod.rs mods
* #55185: path suggestions in Rust 2018 should point out the change in semantics
* #55423: back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch

Note that **this does not update the bootstrap compiler** due to #55404
@pietroalbini pietroalbini added stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Nov 1, 2018
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this pull request Nov 7, 2018
…ark-Simulacrum

Remove `cargo new --edition` from release notes.

This was removed at the last minute (rust-lang#55315, rust-lang/cargo#6216).
Apologies for not catching this.
@pietroalbini pietroalbini added stable-accepted Accepted for backporting to the compiler in the stable channel. and removed stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-accepted Accepted for backporting to the compiler in the stable channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants