-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] Add back Manifest::targets_mut #8534
[beta] Add back Manifest::targets_mut #8534
Conversation
It is needed by cargo-c, it was removed in df5cb70
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
|
Mind cherry-picking #8528 here to get green CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with whatever, just let me know. Do we expect these test failures to lead to problems when integrating into upstream (rust-lang/rust)? |
Ah that's a good point, I think it's fine to just hit merge. I'll work on getting a green CI later for more backports. |
Oh and these are all nightly-only tests so shouldn't cause issues in rust-lang/rust. |
Oh, haha, sorry for giving conflicting advice! These won't fail in rust-lang/rust because they don't run there (all of our nightly-only tests are disabled on rust-lang/rust). |
It is needed by cargo-c, it was removed in df5cb70
This is coupled with stable backport approved yesterday, #8527.