Support finding Windows tools on non-Windows host #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavivie
changed the title
|
@ChrisDenton It would be great if you could give me some advice. |
NobodyXu
requested changes
Jan 21, 2024
cavivie
force-pushed
the
main
branch
6 times, most recently
from
e981e65 to
3162fbe
Compare
NobodyXu
requested changes
Jan 25, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
cc @thomcc I will need your help on how to move forward with this PR |
|
subbing. very interested to be able to use cross for msvc compilation. |
NobodyXu
reviewed
Feb 23, 2024
|
cc @cavivie Can you rebase this please? I'm willing to merge it in. |
Okay, I will do it as soon as possible. |
NobodyXu
requested changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a simple implementation of building targets on non-Windows platform. it supports manually set environment variables to find Windows msvc tools.
By setting
VCINSTALLDIRenvironment variable, we can search msvc tools simply, and resolve related issues:Currently, this PR can be regarded as a draft implementation, and the implementation details may still be discussed.