-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split Tool and ToolFamily to a new tool module #929
Conversation
I'm ok with this changes, but I'm afraid of creating merge conflicts that's a bit hard to fix in other PRs. cc @thomcc what's your thought on this? |
This is just moving code from one file to another. Merge conflicts should be pretty easy to resolve. |
If someone modifies tool impl (e.g. #932 ) then it will have to rewrote it by moving changes into the new file. Wirh rhat said, if #932 is the only PR that will have a merge conflict, then I'm willing to merge this and resolve the conflict myself. |
Sorry, I forgot to hit enter. I was going to say:
But with your comment that it's a single conflicting PR, I think we should go for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but you would need to resolve merge conflicts before I can merge it
Merge conflict fixed. |
No description provided.