[hexagon] Remove aliases w/o leading __ #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These hexagon builtins incorrectly created aliases in the global namespace which can (and in at least one case, did) conflict with symbols defined by other programs. This should address the issue reported as rust-lang/rust#129823: Compiling compiler_builtins v0.1.123 Compiling core v0.0.0 (/home/ben/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core) Compiling rustc-std-workspace-core v1.99.0 (/home/ben/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-core) Compiling byteorder v1.5.0 Compiling zerocopy v0.7.34 error: symbol 'fma' is already defined error: could not compile `compiler_builtins` (lib) due to 1 previous error Also: some of the symbols defined were not just aliases, so those are now qualified with `__hexagon_`. The compiler does not yet emit calls to these particular ones, but if/when it does, it can use the new names.
|
Does changing the symbols from Fyi we get pinged on new PRs already, just need to allow some time for reviews (this PR has only been open 8 hours). |
|
It would, but it was an error to define them that way at all - I don't believe we ever had calls to the unqualified symbols. Probably just an artifact from how it was originally written and tested.
I don't think there is any.
Ok, my mistake. I'm not in any hurry to get this merged, just wanted to avoid it falling through the cracks. Good to know it wouldn't have. |
tgross35
approved these changes
Sep 1, 2024
|
This change will be in 0.1.124, you can put up a PR to rust-lang/rust to update compiler-builtins after #683 merges. |
Ok - will, do. Thanks! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 5, 2024
This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are: * rust-lang/compiler-builtins#682 * rust-lang/compiler-builtins#678 * rust-lang/compiler-builtins#685
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 11, 2024
…ins, r=tgross35 Update compiler-builtins to 0.1.125 This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are: * rust-lang/compiler-builtins#682 * rust-lang/compiler-builtins#678 * rust-lang/compiler-builtins#685 Fixes: rust-lang#129823
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2024
…s, r=<try> Update compiler-builtins to 0.1.125 This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are: * rust-lang/compiler-builtins#682 * rust-lang/compiler-builtins#678 * rust-lang/compiler-builtins#685 try-job: aarch64-apple try-job: aarch64-gnu try-job: armhf-gnu try-job: test-various
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 12, 2024
…ins, r=tgross35 Update compiler-builtins to 0.1.125 This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are: * rust-lang/compiler-builtins#682 * rust-lang/compiler-builtins#678 * rust-lang/compiler-builtins#685
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2024
…s, r=tgross35 Update compiler-builtins to 0.1.125 This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are: * rust-lang/compiler-builtins#682 * rust-lang/compiler-builtins#678 * rust-lang/compiler-builtins#685
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 14, 2024
…ss35 Update compiler-builtins to 0.1.125 This commit updates the compiler-builtins crate from 0.1.123 to 0.1.125. The changes in this update are: * rust-lang/compiler-builtins#682 * rust-lang/compiler-builtins#678 * rust-lang/compiler-builtins#685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hexagon builtins incorrectly created aliases in the global namespace which can (and in at least one case, did) conflict with symbols defined by other programs.
This should address the issue reported as rust-lang/rust#129823:
Also: some of the symbols defined were not just aliases, so those are now qualified with
__hexagon_. The compiler does not yet emit calls to these particular ones, but if/when it does, it can use the new names.