Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexagon: fix symbols defined in global namespace #129921

Closed

Conversation

androm3da
Copy link
Contributor

Update compiler_builtins to 0.1.124:

Some call targets were defined with aliases that could conflict with symbols from a user's program. These aliases have now been deleted or qualified with two leading underscores.

Update `compiler_builtins` to `0.1.124`:

Some call targets were defined with aliases that could conflict
with symbols from a user's program.  These aliases have now been deleted
or qualified with two leading underscores.

* Includes rust-lang/compiler-builtins#682
* Should fix rust-lang#129823
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2024

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@kadiwa4
Copy link
Contributor

kadiwa4 commented Sep 6, 2024

It looks like this is superseded by #129992.

@androm3da
Copy link
Contributor Author

It looks like this is superseded by #129992.

Hmm - so should I close this PR in favor of that one?

@androm3da
Copy link
Contributor Author

It looks like this is superseded by #129992.

Hmm - so should I close this PR in favor of that one?

@Mark-Simulacrum should we review/merge this PR as-is, or defer to the superseding one with more content?

@tgross35
Copy link
Contributor

The updated should be done in all relevant places so we don’t wind up with multiple versions. I just approved #129992, I’ll just close this one since that one should have it covered.

Will also add a fixes tag to that PR to close the hexagon issue.

@tgross35 tgross35 closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hexagon-unknown-none-elf cannot build core, "symbol 'fma' is already defined"
5 participants