-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store & show build logs for non-default targets #2427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
label
Feb 28, 2024
syphar
force-pushed
the
target-build-logs
branch
2 times, most recently
from
February 28, 2024 13:04
2343bdc
to
022fd7a
Compare
Nemo157
reviewed
Feb 29, 2024
syphar
force-pushed
the
target-build-logs
branch
from
February 29, 2024 15:35
022fd7a
to
91db605
Compare
Nemo157
approved these changes
Feb 29, 2024
I was wondering if we could just use "is the filename in the |
github-actions
bot
added
S-waiting-on-deploy
This PR is ready to be merged, but is waiting for an admin to have time to deploy it
and removed
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
labels
Feb 29, 2024
syphar
removed
the
S-waiting-on-deploy
This PR is ready to be merged, but is waiting for an admin to have time to deploy it
label
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #787.
Generally the idea is:
Due to lack of web frontend skills I just added a barely functional way to switch through the logs, I would appreciate help here, though I would also be fine with merging the interface as-is.